GH-50435: [Ruby] Add ArrowFormat::Time{32,64}.new(values)

Author: kou

ruby/red-arrow-format/lib/arrow-format/array.rb

@@ -191,7 +191,7 @@ def initialize(*args)
         type = self.class.type
         expected_n_args = "1 or 3"
       else
-        type = args.shift
+        type = ensure_type(args.shift)
         expected_n_args = "2 or 4"
       end
       args = build_data(args[0], type) if args.size == 1
@@ -259,6 +259,10 @@ def element_size
       IO::Buffer.size_of(@type.buffer_type)
     end
 
+    def ensure_type(type)
+      type
+    end
+
     def build_data(data, type)
       n = 0
       validity_buffer_builder = nil
@@ -461,9 +465,29 @@ class TimeArray < TemporalArray
   end
 
   class Time32Array < TimeArray
+    private
+    def ensure_type(type)
+      case type
+      when Symbol
+        unit = type
+        Time32Type.new(unit)
+      else
+        type
+      end
+    end
   end
 
   class Time64Array < TimeArray
+    private
+    def ensure_type(type)
+      case type
+      when Symbol
+        unit = type
+        Time64Type.new(unit)
+      else
+        type
+      end
+    end
   end
 
   class TimestampArray < TemporalArray

ruby/red-arrow-format/lib/arrow-format/type.rb

@@ -488,6 +488,10 @@ def buffer_type
       :s32
     end
 
+    def pack_template
+      "l"
+    end
+
     def build_array(...)
       Time32Array.new(self, ...)
     end
@@ -506,6 +510,10 @@ def buffer_type
       :s64
     end
 
+    def pack_template
+      "q"
+    end
+
     def build_array(...)
       Time64Array.new(self, ...)
     end

ruby/red-arrow-format/test/test-time32-array.rb

@@ -0,0 +1,60 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+class TestTime32Array < Test::Unit::TestCase
+  def setup
+    @time_00_00_10 = 10
+    @time_00_01_10 = 60 + 10
+  end
+
+  sub_test_case("#initialize") do
+    def test_no_null
+      values = [@time_00_00_10, @time_00_01_10]
+      assert_equal(values,
+                   ArrowFormat::Time32Array.new(:second, values).to_a)
+    end
+
+    def test_mixed
+      values = [@time_00_00_10, nil, @time_00_01_10]
+      assert_equal(values,
+                   ArrowFormat::Time32Array.new(:second, values).to_a)
+    end
+  end
+
+  sub_test_case("#==") do
+    def test_no_slice
+      values = [@time_00_00_10, nil, @time_00_01_10]
+      array1 = ArrowFormat::Time32Array.new(:second, values)
+      array2 = ArrowFormat::Time32Array.new(:second, values)
+      assert_equal(array1, array2)
+    end
+
+    def test_sliced
+      values = [@time_00_00_10, nil, @time_00_01_10]
+      array1 = ArrowFormat::Time32Array.new(:second, values)
+      array2 = ArrowFormat::Time32Array.new(:second, [0, *values, 0])
+      assert_equal(array1, array2.slice(1, 3))
+    end
+
+    def test_sliced_different_content
+      values = [@time_00_00_10, nil, @time_00_01_10]
+      array1 = ArrowFormat::Time32Array.new(:second, values)
+      array2 = ArrowFormat::Time32Array.new(:second, [0, 0, *values, 0])
+      assert_not_equal(array1, array2.slice(1, 3))
+    end
+  end
+end

ruby/red-arrow-format/test/test-time64-array.rb

@@ -0,0 +1,60 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+class TestTime64Array < Test::Unit::TestCase
+  def setup
+    @time_00_00_10_000_000 = 10 * 1_000_000
+    @time_00_01_10_000_000 = (60 + 10) * 1_000_000
+  end
+
+  sub_test_case("#initialize") do
+    def test_no_null
+      values = [@time_00_00_10_000_000, @time_00_01_10_000_000]
+      assert_equal(values,
+                   ArrowFormat::Time64Array.new(:microsecond, values).to_a)
+    end
+
+    def test_mixed
+      values = [@time_00_00_10_000_000, nil, @time_00_01_10_000_000]
+      assert_equal(values,
+                   ArrowFormat::Time64Array.new(:microsecond, values).to_a)
+    end
+  end
+
+  sub_test_case("#==") do
+    def test_no_slice
+      values = [@time_00_00_10_000_000, nil, @time_00_01_10_000_000]
+      array1 = ArrowFormat::Time64Array.new(:microsecond, values)
+      array2 = ArrowFormat::Time64Array.new(:microsecond, values)
+      assert_equal(array1, array2)
+    end
+
+    def test_sliced
+      values = [@time_00_00_10_000_000, nil, @time_00_01_10_000_000]
+      array1 = ArrowFormat::Time64Array.new(:microsecond, values)
+      array2 = ArrowFormat::Time64Array.new(:microsecond, [0, *values, 0])
+      assert_equal(array1, array2.slice(1, 3))
+    end
+
+    def test_sliced_different_content
+      values = [@time_00_00_10_000_000, nil, @time_00_01_10_000_000]
+      array1 = ArrowFormat::Time64Array.new(:microsecond, values)
+      array2 = ArrowFormat::Time64Array.new(:microsecond, [0, 0, *values, 0])
+      assert_not_equal(array1, array2.slice(1, 3))
+    end
+  end
+end