Add Out of bounds IndexError for KeyValueMetadata::Delete

* The Delete function now catches out of bound index
and does not throw a segmentation fault.

Signed-off-by: OmBiradar <ombiradar04@gmail.com>

Author: OmBiradar

cpp/src/arrow/util/key_value_metadata.cc

@@ -100,6 +100,14 @@ Result<std::string> KeyValueMetadata::Get(std::string_view key) const {
 }
 
 Status KeyValueMetadata::Delete(int64_t index) {
+  if (ARROW_PREDICT_FALSE(index < 0 || std::cmp_greater_equal(index, values_.size()))) {
+    return Status::IndexError(
+        "KeyValueMetadata::Delete: index ", std::to_string(index),
+        " is out of bounds for metadata "
+        "of size ",
+        std::to_string(keys_.size()), " (valid range: [0, ",
+        std::to_string((keys_.size() == 0 ? 0UL : keys_.size() - 1)), "])");
+  }
   keys_.erase(keys_.begin() + index);
   values_.erase(values_.begin() + index);
   return Status::OK();

cpp/src/arrow/util/key_value_metadata_test.cc

@@ -187,6 +187,26 @@ TEST(KeyValueMetadataTest, Delete) {
     ASSERT_OK(metadata.Delete(3));
     ASSERT_TRUE(metadata.Equals(
         KeyValueMetadata({"aa", "bb", "dd", "ff", "gg"}, {"1", "2", "4", "6", "7"})));
+
+    std::string expected_error_message =
+        "Index error: KeyValueMetadata::Delete: index -1 is out of bounds for metadata "
+        "of size 5 (valid range: [0, 4])";
+    ASSERT_RAISES_WITH_MESSAGE(IndexError, expected_error_message, metadata.Delete(-1));
+    expected_error_message =
+        "Index error: KeyValueMetadata::Delete: index 7 is out of bounds for metadata "
+        "of size 5 (valid range: [0, 4])";
+    ASSERT_RAISES_WITH_MESSAGE(IndexError, expected_error_message, metadata.Delete(7));
+
+    ASSERT_OK(metadata.Delete(4));
+    ASSERT_OK(metadata.Delete(3));
+    ASSERT_OK(metadata.Delete(2));
+    ASSERT_OK(metadata.Delete(1));
+    ASSERT_OK(metadata.Delete(0));
+
+    expected_error_message =
+        "Index error: KeyValueMetadata::Delete: index 7 is out of bounds for metadata "
+        "of size 0 (valid range: [0, 0])";
+    ASSERT_RAISES_WITH_MESSAGE(IndexError, expected_error_message, metadata.Delete(7));
   }
   {
     KeyValueMetadata metadata(keys, values);