From e1eb97e1bb18528a3d46f6d7db23a36d61e860f0 Mon Sep 17 00:00:00 2001 From: Dewey Dunnington Date: Tue, 16 Dec 2025 22:00:36 -0600 Subject: [PATCH 1/3] skip last byte zeroing (already done) --- python/src/nanoarrow/_buffer.pyx | 4 ---- 1 file changed, 4 deletions(-) diff --git a/python/src/nanoarrow/_buffer.pyx b/python/src/nanoarrow/_buffer.pyx index 14b63b853..4f427e4eb 100644 --- a/python/src/nanoarrow/_buffer.pyx +++ b/python/src/nanoarrow/_buffer.pyx @@ -1150,10 +1150,6 @@ cdef class NoneAwareWrapperIterator: cdef CBuffer validity null_count = self._item_count - self._valid_count - # If we did allocate a bitmap, make sure the last few bits are zeroed - if null_count > 0 and self._bitmap.size_bits % 8 != 0: - ArrowBitmapAppendUnsafe(&self._bitmap, 0, self._bitmap.size_bits % 8) - if null_count > 0: validity = CBuffer.empty() ArrowBufferMove(&self._bitmap.buffer, validity._ptr) From 15ff15f6ea062ae730c56fd3c87330296f82d8e9 Mon Sep 17 00:00:00 2001 From: Dewey Dunnington Date: Tue, 16 Dec 2025 22:16:16 -0600 Subject: [PATCH 2/3] bump to run memcheck for fun --- .github/workflows/verify.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/verify.yaml b/.github/workflows/verify.yaml index aaefa7d7e..ab7660234 100644 --- a/.github/workflows/verify.yaml +++ b/.github/workflows/verify.yaml @@ -139,7 +139,7 @@ jobs: platform: "ubuntu", arch: "amd64", extra_label: "-memcheck", - compose_args: "-e TEST_WITH_MEMCHECK=1 -e TEST_C_BUNDLED=0" + compose_args: "-e TEST_WITH_MEMCHECK=1 -e TEST_C_BUNDLED=0" } - { platform: "ubuntu", From ee95ac66f24f5fa6b36a894ce5a1fac7fee7e90f Mon Sep 17 00:00:00 2001 From: Dewey Dunnington Date: Wed, 17 Dec 2025 09:40:53 -0600 Subject: [PATCH 3/3] remove change introduced to run memcheck --- .github/workflows/verify.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/verify.yaml b/.github/workflows/verify.yaml index ab7660234..aaefa7d7e 100644 --- a/.github/workflows/verify.yaml +++ b/.github/workflows/verify.yaml @@ -139,7 +139,7 @@ jobs: platform: "ubuntu", arch: "amd64", extra_label: "-memcheck", - compose_args: "-e TEST_WITH_MEMCHECK=1 -e TEST_C_BUNDLED=0" + compose_args: "-e TEST_WITH_MEMCHECK=1 -e TEST_C_BUNDLED=0" } - { platform: "ubuntu",