fix(arrow/flight/session): fix flaky race condition test#687
Merged
Conversation
Member
Author
|
Hey, I think i finally got it! |
lidavidm
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Address crash caused by race condition exemplified by https://github.com/apache/arrow-go/actions/runs/22678156759/job/65740770847
When a session is closed, the server removes it from the store and sends a trailer with
Max-Age=0to tell the client to remove the cookie. If the client makes a new request before processing this trailer, it sends the stale cookie with the closed session id. Instead of returningErrNoSessionit got asession not founderror.What changes are included in this PR?
Catch the
session not founderror from the store and returnErrNoSessionso that it properly creates a new session in this case.Are these changes tested?
yes
Are there any user-facing changes?
no