Edit variable button on variable list page

[shubhamraj-git]

related: #43709

Note:
This needs to rebase on #45238, once that is merged.

---

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[shubhamraj-git]

@pierrejeambrun @jscheffl @bbovenzi

I can see that the patch variable api have a check

if patch_body.key != variable_key:
        raise HTTPException(
            status.HTTP_400_BAD_REQUEST, "Invalid body, key from request body doesn't match uri parameter"
        )
    non_update_fields = {"key"}

Is this introduced new that we can't edit the variable key?
I checked in the legacy UI and I was able to edit it.

[jscheffl]

Looks good for me. LGTM!

(we could debate if it makes sense to add a "ManageVariable" subfolder just for the CRUD elements but actually that is rather cosmetic)

[shubhamraj-git]

@jscheffl I am open to suggestion on this, if we have something better.
My only take on this was, we are going to have import vars, export var, delete multiple, action bars soon. So, it will contain lot of files, so just made the proper CRUD under a folder.

[jscheffl]

@pierrejeambrun @jscheffl @bbovenzi

I can see that the patch variable api have a check

if patch_body.key != variable_key:
        raise HTTPException(
            status.HTTP_400_BAD_REQUEST, "Invalid body, key from request body doesn't match uri parameter"
        )
    non_update_fields = {"key"}

Is this introduced new that we can't edit the variable key? I checked in the legacy UI and I was able to edit it.

I believe that this is an artefact from the migration of public API from Connexion to Fast API, this validation was converted 1:1.
The legacy UI was not using the public API but was directly writing to DB.

So technically we have two options:

1. Restrict changing the key in UI, make the key field read-only when editing
2. Remove the validation in Rest API
3. Add a UI specific API just for this

From UI Perspective dis-allowing to change the key does not make sense. So I'd propose to remove the validation in REST API. For option 1 I see no reason. And Option 3 is too much overhead just because of a cross-validation in API

Any other opinions?

[shubhamraj-git]

@pierrejeambrun @jscheffl @bbovenzi

I can see that the patch variable api have a check

if patch_body.key != variable_key:
        raise HTTPException(
            status.HTTP_400_BAD_REQUEST, "Invalid body, key from request body doesn't match uri parameter"
        )
    non_update_fields = {"key"}

Is this introduced new that we can't edit the variable key? I checked in the legacy UI and I was able to edit it.

Also regrading this issue.

If we plan to implement this.

1. I can have a PR where I will disable the key edit.
2. But if we chose to remove this check from backend, I can have a PR to do that.

[shubhamraj-git]

I believe that this is an artefact from the migration of public API from Connexion to Fast API, this validation was converted 1:1. The legacy UI was not using the public API but was directly writing to DB.

So technically we have two options:

1. Restrict changing the key in UI, make the key field read-only when editing
2. Remove the validation in Rest API
3. Add a UI specific API just for this

From UI Perspective dis-allowing to change the key does not make sense. So I'd propose to remove the validation in REST API. For option 1 I see no reason. And Option 3 is too much overhead just because of a cross-validation in API

Any other opinions?

Regarding option 1)
If we change the key itself, I think we actually created a new variable itself, Isn't this contradicting to edit behaviour? Like users will need to actual change the references too in that case.

I think this can have a discussion and can be fixed later in other PR, what say?