Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deferrable support for HttpOperator #45228

Merged
merged 6 commits into from
Jan 17, 2025
Merged

Deferrable support for HttpOperator #45228

merged 6 commits into from
Jan 17, 2025

Conversation

TakayukiTanabeSS
Copy link
Contributor

Enabling deferrable for HttpOperator causes an error.
The minimum test case is as follows

import datetime

from airflow import DAG
from airflow.operators.empty import EmptyOperator
from airflow.providers.http.operators.http import HttpOperator

with DAG(
    dag_id="my_dag_name",
    catchup=False,
) as dag:

    test = HttpOperator(
        task_id="test",
        method="GET",
        http_conn_id="google_http_default",
        endpoint="search?q=airflow",
        log_response=True,
        deferrable=True,
    )

    EmptyOperator(task_id="start") >> test >> EmptyOperator(task_id="end")

For connections, set Connection Id to “google_http_default”, Connection Type to “HTTP” and HOST to “https://www.google.com”.

If you place it in airflow/files/dags/ and run it you will get the following error

[2024-12-27, 01:53:21 UTC] {taskinstance.py:3311} ERROR - Task failed with exception
Traceback (most recent call last):
  File "/opt/airflow/airflow/models/taskinstance.py", line 767, in _execute_task
    result = _execute_callable(context=context, **execute_callable_kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/airflow/airflow/models/taskinstance.py", line 733, in _execute_callable
    return ExecutionCallableRunner(
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/airflow/airflow/utils/operator_helpers.py", line 252, in run
    return self.func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/airflow/airflow/models/baseoperator.py", line 1814, in resume_execution
    return execute_callable(context)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/airflow/airflow/providers/http/operators/http.py", line 261, in execute_complete
    raise AirflowException(f"Unexpected error in the operation: {event['message']}")
airflow.exceptions.AirflowException: Unexpected error in the operation: Connection closed.

Causes:.

https://github.com/apache/airflow/blob/9178f8f0b1ffd80b8eacf4d02b732528fde218e5/providers/src/airflow/providers/http/triggers/http .py#L97
A session object is created by the above caller.

It is at the following link
https://github.com/apache/airflow/blob/9178f8f0b1ffd80b8eacf4d02b732528fde218e5/providers/src/airflow/providers/http/hooks/http.py #L413

The following is then called.
https://github.com/apache/airflow/blob/9178f8f0b1ffd80b8eacf4d02b732528fde218e5/providers/src/airflow/providers/http/triggers/http .py#L103

https://github.com/apache/airflow/blob/9178f8f0b1ffd80b8eacf4d02b732528fde218e5/providers/src/airflow/providers/http/triggers/http .py#L117
It is expected that the ClientSession is alive at this point, but it is already out of scope and disconnected.

To properly correct this, we changed the configuration to the following Previously, the opposite was the case, which caused the bug.

Correct.
ClientSession scope {
ClientResponse scope{
response.read
}
}

Incorrect
ClientResponse scope {
ClientSession scope {
}
response.read expect session living (error)
}

With the interface changes, we modified the required tests, re-ran the required tests, and verified that they completed successfully. I would be happy to check and review! Best regards.

Takayuki Tanabe

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Dec 27, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal requested a review from Lee-W December 29, 2024 04:49
Lee-W
Lee-W reviewed Jan 2, 2025
View reviewed changes
providers/src/airflow/providers/http/hooks/http.py Outdated Show resolved Hide resolved
providers/src/airflow/providers/http/hooks/http.py Outdated Show resolved Hide resolved
providers/src/airflow/providers/http/hooks/http.py Outdated Show resolved Hide resolved
providers/src/airflow/providers/http/hooks/http.py Outdated Show resolved Hide resolved
providers/src/airflow/providers/http/hooks/http.py Outdated Show resolved Hide resolved
@TakayukiTanabeSS TakayukiTanabeSS force-pushed the fix_http_operator_deferrable_v4 branch from 5daaacd to b4d0b88 Compare January 3, 2025 15:40
@TakayukiTanabeSS
Copy link
Contributor Author

@Lee-W Thank you for reviewing! I will resume work on this matter from January 6th, so please wait for two days.

@TakayukiTanabeSS
Copy link
Contributor Author

@Lee-W I've made modifications according to your review! Please check again.

@TakayukiTanabeSS TakayukiTanabeSS requested a review from Lee-W January 6, 2025 07:22
Lee-W
Lee-W approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry for taking so long. Thanks for your contribution! Everything looks good and we're in a good shape to merge. I'll keep it open for 1 or 2 days so that others can check as well. Please ping me again if I forget to merge it. Thanks!

@Lee-W
Copy link
Member

Lee-W commented Jan 14, 2025

The CI seems weird 🤔 let me rebase and see how it works

@Lee-W Lee-W force-pushed the fix_http_operator_deferrable_v4 branch from 052b6b2 to 470678d Compare January 14, 2025 02:52
@TakayukiTanabeSS
Copy link
Contributor Author

Thank you!
It was a great experience working with you.

@Lee-W
Copy link
Member

Lee-W commented Jan 15, 2025

Thank you! It was a great experience working with you.

Opps, I notice there's a static check error. Should be a quick fix. 🙂

@TakayukiTanabeSS TakayukiTanabeSS force-pushed the fix_http_operator_deferrable_v4 branch from 470678d to 9c83c8a Compare January 16, 2025 07:37
@TakayukiTanabeSS
Copy link
Contributor Author

i did rebase and work on the quick fix!

@TakayukiTanabeSS
Copy link
Contributor Author

@Lee-W Corrections have been made concerning the linter! Please check.

@Lee-W Lee-W merged commit f3666e7 into apache:main Jan 17, 2025
61 checks passed
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Jan 17, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-W Lee-W Lee-W approved these changes

Assignees
No one assigned
Labels
area:providers provider:http
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TakayukiTanabeSS @Lee-W