Skip to content

Commit bf2e7d8

Browse files
goingforstudying-ctrlgoingforstudying-ctrl
authored andcommitted
fix: use create_autospec(Transport) for remaining mock_transport_type instances
Apply reviewer's suggestion consistently across all three test methods that instantiate mock_transport_type, not just the one originally flagged.
1 parent 89dea67 commit bf2e7d8

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

providers/google/tests/unit/google/cloud/log/test_stackdriver_task_handler.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ def test_prepare_log_filter_with_custom_resource(self, mock_get_creds_and_projec
278278
def test_processors_sends_to_transport(self, mock_client, mock_get_creds_and_project_id):
279279
mock_get_creds_and_project_id.return_value = ("creds", "project_id")
280280

281-
mock_transport_type = mock.MagicMock()
281+
mock_transport_type = mock.create_autospec(Transport)
282282
with mock.patch("airflow.sdk.log.relative_path_from_logger", return_value="dag/task/1.log"):
283283
io = StackdriverRemoteLogIO(
284284
base_log_folder=self.local_log_location,
@@ -311,7 +311,7 @@ def test_processors_sends_to_transport(self, mock_client, mock_get_creds_and_pro
311311
def test_processors_skips_non_task_logger(self, mock_client, mock_get_creds_and_project_id):
312312
mock_get_creds_and_project_id.return_value = ("creds", "project_id")
313313

314-
mock_transport_type = mock.MagicMock()
314+
mock_transport_type = mock.create_autospec(Transport)
315315
with mock.patch("airflow.sdk.log.relative_path_from_logger", return_value=None):
316316
io = StackdriverRemoteLogIO(
317317
base_log_folder=self.local_log_location,

0 commit comments

Comments
 (0)