Skip to content

Commit 98655a7

Browse files
committed
Move RuboCop version pinning into Gemfile
We were declaring the pinned version of RuboCop as a development dependency in the gemspec. This turns out to not be technically correct, as it's not really a development dependency, but a testing one (i.e. we don't want to enforce this requirement for developers using this gem when developing other gems that require this gem). It turns out a way get around this is to declare the pinned version in the `Gemfile`. Change-Id: Ifa27a9c2cec89297300fc99f0aae483839eb636c Reviewed-on: http://gerrit.causes.com/44724 Tested-by: jenkins <[email protected]> Reviewed-by: Shane da Silva <[email protected]>
1 parent a9d86d0 commit 98655a7

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

Gemfile

+7
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
11
source 'http://rubygems.org'
22

33
gemspec
4+
5+
# Pin Rubocop for Travis builds.
6+
# This won't affect people installing via `gem install` since it's not in the
7+
# gemspec. It needs to come before the call to `gemspec` below in order to
8+
# prevent a warning being displayed about duplicate dependencies when running
9+
# `bundle install` in this repository.
10+
gem 'rubocop', '0.27.1'

scss-lint.gemspec

-1
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,4 @@ Gem::Specification.new do |s|
2929

3030
s.add_development_dependency 'nokogiri', '~> 1.6.0'
3131
s.add_development_dependency 'rspec', '~> 3.0'
32-
s.add_development_dependency 'rubocop', '0.27.1'
3332
end

0 commit comments

Comments
 (0)