Repository navigation
docs: small rustdoc, guide and error message fixes from #709 - #713
Merged
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
…sion PoolError::MessageSetWithFields is not in a release, so a Changed entry for its text would describe a change no user sees. The editions_2024 test module names protoc v32+ like the build script. The guide sentence about the chrono and jiff conversions sits with the Timestamp and Duration sentence it refers to, and five long lines are wrapped.
iainmcgin
reviewed
Oct 14, 2026
iainmcgin
left a comment
Collaborator
There was a problem hiding this comment.
[claude code] Pushed one commit (fe87875):
- Removed the
Changedfragment.PoolError::MessageSetWithFieldswas added by #599 and is not in a release yet, so the release notes would describe a change to a text that users have not seen. buffa-test/src/tests/editions_2024.rsalso said "protoc v30+"; it now says v32+. The issue did not list it.- In the guide, the
chronoandjiffsentence moved up beside theTimestampandDurationsentence it refers to. With the wrapper sentences in between, "This" read as the wrappers. That placement came from the issue text. - Five added lines are wrapped to the width of the lines around them.
Contributor
Author
|
Thanks — those fixes look right, especially dropping the unreleased Changed entry and moving the chrono/jiff sentence so This points at Timestamp/Duration again. |
iainmcgin
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #709
Applies the checklist items from #709:
UnknownFields: rustdoc on theExtendandFromIteratorimpls.docs/guide.md: by-reference conversions now mention the numeric andboolwrappers, and thatStringValue/BytesValueconvert by value only.PoolError::NameTooLong: doc lists which names are checked (field and oneof names are not).symbol_conflicts.rs: renamedfield_and_oneof_names_do_not_gain_a_length_limittofield_and_oneof_names_longer_than_max_symbol_len_link.PoolError::MessageSetWithFields: display text is now "MessageSet {message} declares a field; a MessageSet can have extensions only"; expected string inpool_e2e.rsupdated; changelog fragment added.CONTRIBUTING.md:8,buffa-test/build.rs,README.md,docs/guide.mdandbuffa-build/README.md.decode_from_str_with_element_memory_limit: first doc sentence says the budget is in bytes.Not changed:
CONTRIBUTING.md:88and theconformance-localdescription inTaskfile.yml(protoc v30+ for the native conformance run), since the issue leaves those conditional on the reason being edition 2024.Testing (toolchain 1.95.0):
cargo test -p buffa-descriptor --all-features: all pass;messageset_declared_fields_are_rejected_transactionallyfails with the old message and passes with the new one.cargo test -p buffa --all-features --lib unknown_fields: pass.cargo fmt --all -- --check,cargo clippy -p buffa -p buffa-descriptor --all-features --all-targets,RUSTDOCFLAGS="-D warnings" cargo doc -p buffa -p buffa-descriptor --all-features --no-deps: clean.