Repository navigation
reflect: require slash-delimited Any type URLs - #524
Closed
fallintoplace wants to merge 1 commit into
Closed
fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Collaborator
|
[claude code] Thank you for this PR: it is what showed that buffa's two JSON parsers disagreed about an We settled the disagreement in the other direction, in #692. protobuf-go and Python read a bare name, and C++ and Java reject it, so #692 makes both parsers accept a bare name that resolves to a known message, and adds an option on each for the behaviour this PR implements:
The other inputs this PR tests are errors with the option on or off: an #692 supersedes this PR, so it will be closed. If the strict option is missing a case you had in mind, a comment on #692 is the best place for it. |
Luccacvb
pushed a commit
to Luccacvb/buffa
that referenced
this pull request
Oct 10, 2026
…#692) A `google.protobuf.Any` whose `type_url` has no `/` was resolved by `DynamicMessage` and rejected by the generated `Any` JSON parser. `any.proto` requires the `/`; protobuf-go and Python read a bare full name anyway, and C++ and Java reject it. - The generated `Any` JSON parser accepts `{"@type": "pkg.Message", ...}` when the type registry has a JSON entry for `pkg.Message`. Such an `Any` is now written expanded; it was written as base64 under `value`, which the same parser rejected. A payload that does not decode as that message now fails to serialize. - A bare name that does not resolve is a parse error and never takes the base64 form. The conformance test `AnyWktRepresentationWithBadType` requires that. The serializer still writes the base64 form for such an `Any`, so it does not round-trip. - `AnyRegistry::lookup` and `TypeRegistry::json_any_by_url` find an entry by a bare name, and an entry registered under a bare name is found under any URL prefix. - `Any::type_name`, `is_message` and `unpack_message` (unreleased, anthropics#499) read a URL without a `/` as the name. - `JsonParseOptions::strict_any_type_urls` and `DynamicMessageSeed::strict_any_type_urls` reject an `@type` without a `/`, at any depth of `Any` in `Any`. The reflective seeds pass both parse options down in one `ParseFlags` value, which is most of the change in `reflect/json.rs`. ```rust let opts = JsonParseOptions::new().strict_any_type_urls(true); let msg = with_json_parse_options(&opts, || serde_json::from_str::<MyMsg>(json))?; ``` Serialization, `DynamicMessage::unpack_any` and `Any::type_name` take no options and resolve a bare name. Text format does not resolve a bare name, because `[pkg.Message] { ... }` is the syntax of an extension field. The error for an empty `@type`, or one ending in `/`, now reads `@type "..." is not a valid type URL: it names no type`. The changelog entry is `Changed`. anthropics#485, which changed the same output for a URL with an unregistered prefix, is filed under `Breaking changes`; 0.9.2 could not parse a bare `@type` at all, so less depends on the old output here. Supersedes anthropics#524, which made the reflective path reject a bare name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Implementation