Skip to content

FIX: ibis buffer placement #6924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 24, 2025
Merged

FIX: ibis buffer placement #6924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d53a863
Fixed method which was importing all buffers while only few where typ…
maxcapodi78 Nov 21, 2025
da376df
Fixed method which was importing all buffers while only few where typ…
maxcapodi78 Nov 21, 2025
3b7cde0
chore: adding changelog file 6924.fixed.md [dependabot-skip]
pyansys-ci-bot Nov 21, 2025
126d7ce
Fixed unit test and added model_selectors to check
maxcapodi78 Nov 24, 2025
e065714
Merge remote-tracking branch 'origin/fix_ibis_buffer_placement' into …
maxcapodi78 Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/6924.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Ibis buffer placement
136 changes: 100 additions & 36 deletions src/ansys/aedt/core/generic/ibis_reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ def add(self):
try:
available_names = self._circuit.modeler.schematic.ocomponent_manager.GetNames()
if self.name not in available_names:
self._app._app.import_model_in_aedt()
self._app._app.import_model_in_aedt(pins=self.name)
return self._circuit.modeler.schematic.ocomponent_manager.AddSolverOnDemandModel(
self.buffer_name,
[
Expand Down Expand Up @@ -323,8 +323,8 @@ def insert(self, x, y, angle=0.0, page=1):
Circuit Component Object.

"""
if self.buffer_name not in self._circuit.modeler.schematic.ocomponent_manager.GetNames():
self._app._app.import_model_in_aedt()
if self.name not in self._circuit.modeler.schematic.ocomponent_manager.GetNames():
self._app._app.import_model_in_aedt(pins=self.name)
return self._circuit.modeler.schematic.create_component(
component_library=None,
component_name=self.buffer_name,
Expand Down Expand Up @@ -451,8 +451,8 @@ def add(self):
"""Add a pin to the list of components in the Project Manager."""
try:
available_names = self._circuit.modeler.schematic.ocomponent_manager.GetNames()
if self.buffer_name not in available_names:
self._app.import_model_in_aedt()
if self.name not in available_names:
self._app.import_model_in_aedt(pins=self.name)
return self._circuit.modeler.schematic.ocomponent_manager.AddSolverOnDemandModel(
self.buffer_name,
[
Expand Down Expand Up @@ -495,8 +495,8 @@ def insert(self, x, y, angle=0.0, page=1):
Circuit Component Object.

"""
if self.buffer_name not in self._circuit.modeler.schematic.ocomponent_manager.GetNames():
self._app.import_model_in_aedt()
if self.name not in self._circuit.modeler.schematic.ocomponent_manager.GetNames():
self._app.import_model_in_aedt(pins=self.name)
return self._circuit.modeler.schematic.create_component(
component_library=None,
component_name=self.buffer_name,
Expand Down Expand Up @@ -527,7 +527,7 @@ def add(self):
"""Add a buffer to the list of components in the Project Manager."""
available_names = self._circuit.modeler.schematic.ocomponent_manager.GetNames()
if self.name not in available_names:
self._app.import_model_in_aedt()
self._app.import_model_in_aedt(buffers=self.name)
self._circuit.modeler.schematic.ocomponent_manager.AddSolverOnDemandModel(
self.name,
[
Expand Down Expand Up @@ -567,8 +567,9 @@ def insert(self, x, y, angle=0.0, page=1):
Circuit Component Object.

"""
if self.name not in self._circuit.modeler.schematic.ocomponent_manager.GetNames():
self._app.import_model_in_aedt()
all_names = self._circuit.modeler.schematic.ocomponent_manager.GetNames()
if self.name not in all_names:
self._app.import_model_in_aedt(buffers=self.name)
return self._circuit.modeler.schematic.create_component(
component_library=None, component_name=self.name, location=[x, y], angle=angle, page=page
)
Expand Down Expand Up @@ -891,17 +892,35 @@ def parse_ibis_file(self):

return ibis_info

def import_model_in_aedt(self):
def import_model_in_aedt(self, pins=None, buffers=None):
"""Check and import the ibis model in AEDT.

Parameters
----------
pins : list,str, optional
Pin to import.
buffers : list, str, optional
Buffers to import.

Returns
-------
bool
``True`` when the model is imported successfully, ``False`` if not imported or model already present.

"""
names = [i.name for i in self._ibis_model.buffers.values()]
if [i for i in self._circuit.modeler.schematic.ocomponent_manager.GetNames() if i in names]:
if buffers is None:
buffers = []
elif isinstance(buffers, str):
buffers = [buffers]
if pins is None:
pins = []
elif isinstance(pins, str):
pins = [pins]
bufs = [i.name for i in self._ibis_model.buffers.values()]
model_names = [i.name for i in self._ibis_model.models] + [i.name for i in self._ibis_model.model_selectors]
bufs = [i for i in bufs if i not in self._circuit.modeler.schematic.ocomponent_manager.GetNames()]

if not bufs and not (buffers or pins):
return False

if self._circuit:
Expand All @@ -919,23 +938,32 @@ def import_model_in_aedt(self):
arg_buffers = ["NAME:Buffers"]
for buffer_item in self._ibis_model.buffers.values():
arg_buffers.append(f"{buffer_item.short_name}:=")
arg_buffers.append([True, "IbisSingleEnded"])
# model_selector_names = [i.name for i in self._ibis_model.model_selectors]
arg_buffers.append(
[True if (not buffers and not pins) or buffer_item.name in buffers else False, "IbisSingleEnded"]
)
arg_components = ["NAME:Components"]
for comp_value in self._ibis_model.components.values():
arg_component = [f"NAME:{comp_value.name}"]
for pin in comp_value.pins.values():
arg_component.append(f"{pin.short_name}:=")
# if pin.model not in model_selector_names:
# arg_component.append([False, False])
# else:
arg_component.append([True, False])
arg_component.append(
[
True
if pin.model in model_names and ((not buffers and not pins) or pin.name in pins)
else False,
False,
]
)
for pin in comp_value.differential_pins.values():
arg_component.append(f"{pin.short_name}:=")
# if pin.model not in model_selector_names:
# arg_component.append([False, True])
# else:
arg_component.append([True, True])
arg_component.append(
[
True
if pin.model in model_names and ((not buffers and not pins) or pin.name in pins)
else False,
True,
]
)
arg_components.append(arg_component)

args.append(arg_buffers)
Expand Down Expand Up @@ -1321,10 +1349,30 @@ def parse_ibis_file(self):
self._ibis_model = ibis
return ibis_info

def import_model_in_aedt(self):
names = [i.name for i in self._ibis_model.buffers.values()]
if [i for i in self._circuit.modeler.schematic.ocomponent_manager.GetNames() if i in names]:
def import_model_in_aedt(self, pins=None, buffers=None):
"""Check and import the ibis model in AEDT.

Returns
-------
bool
``True`` when the model is imported successfully, ``False`` if not imported or model already present.

"""
if buffers is None:
buffers = []
elif isinstance(buffers, str):
buffers = [buffers]
if pins is None:
pins = []
elif isinstance(pins, str):
pins = [pins]
bufs = [i.name for i in self._ibis_model.buffers.values()]
bufs = [i for i in bufs if i not in self._circuit.modeler.schematic.ocomponent_manager.GetNames()]
model_names = [i.name for i in self._ibis_model.models] + [i.name for i in self._ibis_model.model_selectors]

if not bufs and not (buffers or pins):
return False

if self._circuit:
args = [
"NAME:Options",
Expand All @@ -1340,23 +1388,39 @@ def import_model_in_aedt(self):
arg_buffers = ["NAME:Buffers"]
for buffer in self._ibis_model.buffers:
arg_buffers.append(f"{self._ibis_model.buffers[buffer].short_name}:=")
arg_buffers.append([True, "IbisSingleEnded"])
# model_selector_names = [i.name for i in self._ibis_model.model_selectors]
arg_buffers.append(
[
True
if (not buffers and not pins) or self._ibis_model.buffers[buffer].name in buffers
else False,
"IbisSingleEnded",
]
)
arg_components = ["NAME:Components"]
for component in self._ibis_model.components:
arg_component = [f"NAME:{self._ibis_model.components[component].name}"]
for pin in self._ibis_model.components[component].pins.values():
arg_component.append(f"{pin.short_name}:=")
# if model_selector_names and pin.model not in model_selector_names:
# arg_component.append([False, False])
# else:
arg_component.append([True, False])
arg_component.append(
[
True
if pin.model in model_names and ((not buffers and not pins) or pin.name in pins)
else False,
False,
]
)

for pin in self._ibis_model.components[component].differential_pins.values():
arg_component.append(f"{pin.short_name}:=")
# if model_selector_names and pin.model not in model_selector_names:
# arg_component.append([False, True])
# else:
arg_component.append([True, True])
arg_component.append(
[
True
if pin.model in model_names and ((not buffers and not pins) or pin.name in pins)
else False,
True,
]
)

arg_components.append(arg_component)

args.append(arg_buffers)
Expand Down
Loading