Skip to content

FIX: Choke designer issues #5915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 15, 2025
Merged

FIX: Choke designer issues #5915

merged 7 commits into from
Mar 15, 2025

Conversation

Samuelopez-ansys
Copy link
Member

Description

Choke designer exceptions

Issue linked

Close #5913

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Mar 14, 2025
@Samuelopez-ansys Samuelopez-ansys mentioned this pull request Mar 14, 2025
Closed
2 tasks
@codecov Codecov
Copy link

codecov bot commented Mar 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.94%. Comparing base (c82ca70) to head (a1e4f69).
Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5915      +/-   ##
==========================================
- Coverage   84.96%   84.94%   -0.02%     
==========================================
  Files         162      162              
  Lines       62303    62305       +2     
==========================================
- Hits        52933    52926       -7     
- Misses       9370     9379       +9
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

SMoraisAnsys
SMoraisAnsys previously approved these changes Mar 14, 2025
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left minor comments.

SMoraisAnsys
SMoraisAnsys reviewed Mar 14, 2025
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left minor comments.

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) March 14, 2025 14:13
@Samuelopez-ansys Samuelopez-ansys marked this pull request as draft March 15, 2025 07:46
auto-merge was automatically disabled March 15, 2025 07:46

Pull request was converted to draft

@Samuelopez-ansys Samuelopez-ansys marked this pull request as ready for review March 15, 2025 07:49
svandenb-dev
svandenb-dev approved these changes Mar 15, 2025
View reviewed changes
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit f52eb6c into main Mar 15, 2025
46 of 47 checks passed
@svandenb-dev svandenb-dev deleted the fix/choke_extension branch March 15, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMoraisAnsys SMoraisAnsys SMoraisAnsys left review comments

@svandenb-dev svandenb-dev svandenb-dev approved these changes

@maxcapodi78 maxcapodi78 Awaiting requested review from maxcapodi78

@gmalinve gmalinve Awaiting requested review from gmalinve

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Choke designer crashes
4 participants
@Samuelopez-ansys @svandenb-dev @SMoraisAnsys @pyansys-ci-bot