Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR: populate pyvista object refactoring #5887

Merged
merged 32 commits into from
Mar 19, 2025
Merged

REFACTOR: populate pyvista object refactoring #5887

merged 32 commits into from
Mar 19, 2025

Conversation

gmalinve
Copy link
Contributor

@gmalinve gmalinve commented Mar 10, 2025 •
edited
Loading

Description

In this PR we improve the method populate_pyvista_object in order to be able to handle vector fields. So far we were only able to handle scalar fields.
In the UTs I test that the method works for all three types of field files: .fld, .aedtplt, .case.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@Devin-Crawford @gmalinve
Modify info message
46107a2 
- info message is a bit more polite.

(cherry picked from commit 03371f7)
@Devin-Crawford @gmalinve
fixes
4a008a8
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement New features or code improvements label Mar 10, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 84.99%. Comparing base (0d1055f) to head (9d046ad).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5887      +/-   ##
==========================================
+ Coverage   84.95%   84.99%   +0.04%     
==========================================
  Files         162      162              
  Lines       62304    62358      +54     
==========================================
+ Hits        52929    53000      +71     
+ Misses       9375     9358      -17
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added the testing Anything related to testing label Mar 11, 2025
Devin-Crawford
Devin-Crawford previously approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@Devin-Crawford Devin-Crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. This seems like a good solution in the near-term.

@gmalinve gmalinve self-assigned this Mar 13, 2025
@gmalinve gmalinve linked an issue Mar 13, 2025 that may be closed by this pull request
Improve pyvista to be able to handle vector fields #5905
Closed
@gmalinve gmalinve changed the title REFACTOR: post processing refactoring REFACTOR: populate pyvista object refactoring Mar 18, 2025
@gmalinve gmalinve marked this pull request as ready for review March 18, 2025 10:21
@gmalinve gmalinve requested a review from SMoraisAnsys March 18, 2025 10:21
SMoraisAnsys
SMoraisAnsys previously requested changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution ! Great refactoring :)

Could you answer some of my questions and address a few proposed changes ? The function renaming can be performed later (but it would be great to do it)

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) March 18, 2025 21:56
Samuelopez-ansys
Samuelopez-ansys previously approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys dismissed SMoraisAnsys’s stale review March 19, 2025 10:13

Requests implemented

@Samuelopez-ansys Samuelopez-ansys merged commit eb5b6fc into main Mar 19, 2025
46 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the feat/post_processing_devin branch March 19, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samuelopez-ansys Samuelopez-ansys Samuelopez-ansys approved these changes

@Devin-Crawford Devin-Crawford Devin-Crawford left review comments

@SMoraisAnsys SMoraisAnsys SMoraisAnsys left review comments

@maxcapodi78 maxcapodi78 Awaiting requested review from maxcapodi78

Assignees

@gmalinve gmalinve

Labels
enhancement New features or code improvements testing Anything related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve pyvista to be able to handle vector fields
6 participants
@gmalinve @Devin-Crawford @Samuelopez-ansys @SMoraisAnsys @pyansys-ci-bot @maxcapodi78