Fix inventoryID issue with Job resource #32

abikouo · 2024-06-25T15:05:27Z

Closes #31

Fix issue when create Job resource using Job template ID which does not allow running with a different inventory ID (Template does not prompt for inventory Id at launch)
Update acceptance tests to validate inventory Id

gravesm · 2024-07-03T17:48:19Z

internal/provider/job_resource.go

+	if r.InventoryID.ValueInt64() == 0 {
+		r.InventoryID = types.Int64Value(resultApiJob.Inventory)
+	}


I feel like the bug this is trying to fix was introduced by https://github.com/ansible/terraform-provider-aap/pull/10/files#diff-afd9b829236927b85ef1814941bb6f012eed9cca71547f9f9ce15dcceb29a6f4R216-R219. I don't know why that change was made, but, among other things, it makes it impossible to use a job template that has a default inventory and is configured to prompt on launch. I think fixing that bug makes this bug go away, because it shouldn't be possible to launch a job with prompt on launch and no default inventory set.

Fix inventoryID issue with Job resource

6d8e536

abikouo force-pushed the job_resource_issue_31 branch from 6c9affc to 6d8e536 Compare July 2, 2024 14:25

gravesm reviewed Jul 3, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix inventoryID issue with Job resource #32

Fix inventoryID issue with Job resource #32

abikouo commented Jun 25, 2024

gravesm Jul 3, 2024 •

edited

Loading

Fix inventoryID issue with Job resource #32

Are you sure you want to change the base?

Fix inventoryID issue with Job resource #32

Conversation

abikouo commented Jun 25, 2024

gravesm Jul 3, 2024 • edited Loading

Choose a reason for hiding this comment

gravesm Jul 3, 2024 •

edited

Loading