common: Handle aliases correctly

Fixed get_api_client API to handle `aliases` that
are passed via inventory configuration or module parameters.

Signed-off-by: Abhijeet Kasurde <[email protected]>

Author: Akasurde

changelogs/fragments/honor_aliases.yml

@@ -0,0 +1,2 @@
+bugfixes:
+- common - handle ``aliases`` passed from inventory or module params.

molecule/default/tasks/full.yml

@@ -10,6 +10,20 @@
       debug:
         var: output
 
+    - name: Use aliases and check if those values are picked up
+      k8s:
+        name: testing
+        kind: Namespace
+        validate_certs: yes
+        ssl_ca_cert: /dev/null  # invalid CA certificate
+      ignore_errors: yes
+      register: output
+
+    - name: assert that ssl_ca_cert caused a failure (and therefore was correctly translated to ssl_ca_cert)
+      assert:
+        that:
+          - output is failed
+
     - name: Setting validate_certs to true causes a failure
       k8s:
         name: testing

plugins/module_utils/common.py

@@ -129,8 +129,15 @@ def _raise_or_fail(exc, msg):
 
     # If authorization variables aren't defined, look for them in environment variables
     for true_name, arg_name in AUTH_ARG_MAP.items():
-        if module and module.params.get(arg_name):
-            auth[true_name] = module.params.get(arg_name)
+        if module:
+            if arg_name in module.params and module.params.get(arg_name) is not None:
+                auth[true_name] = module.params.get(arg_name)
+            elif true_name in module.params and module.params.get(true_name) is not None:
+                # Aliases
+                auth[true_name] = module.params.get(true_name)
+        elif true_name in kwargs and kwargs.get(true_name) is not None:
+            # Aliases
+            auth[true_name] = kwargs.get(true_name)
         elif arg_name in kwargs and kwargs.get(arg_name) is not None:
             auth[true_name] = kwargs.get(arg_name)
         else:

tests/integration/targets/kubernetes/tasks/validate_not_installed.yml

@@ -18,6 +18,10 @@
   ignore_errors: yes
   register: k8s_no_validate
 
+- name: Debug register value
+  debug:
+    msg: "{{ k8s_no_validate }}"
+
 - name: assert that k8s_no_validate fails gracefully
   assert:
     that: