Skip to content
Closed
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Prettify code
uses: creyD/[email protected]
with:
prettier_options: "--write src/**/*.{ts,jsx,js,css,html,json,md}"
prettier_options: --write src/**/*.{ts,jsx,js,css,html,json,md}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed, is there any reason why this was reverted and why package-lock.json and yarn.lock have so many changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that the quotes are not necessary (and not suggested in the plugin's official documentation) so I removed it!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package-lock has a lot of changes because I tried to rebase it with develop (it still fails)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert those file changes (yarn.lock and package-lock.json)? And keep this PR to the changes related to the ticket?

only_changed: True
build:
# The type of runner that the job will run on
Expand Down
31 changes: 15 additions & 16 deletions .github/workflows/pr-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,28 @@ name: PR Safe Check

on:
pull_request:
branches: [ develop ]
branches: [develop]
types: [opened, synchronize, reopened]
push:
branches: [ develop ]
branches: [develop]

jobs:
build_check:

runs-on: ubuntu-latest
strategy:
matrix:
node: [ '14', '16' ]
node: ['14', '16']
name: Node.js v${{ matrix.node }}
steps:
- name: 🛎 Checkout
uses: actions/checkout@v2
- name: 🚀 Use Node.js
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node }}
- name: ⚙️ Install dependencies
run: npm install
- name: 🔍 Run tests
run: npm test
- name: 🔨 Build the project
run: npm run build
- name: 🛎 Checkout
uses: actions/checkout@v2
- name: 🚀 Use Node.js
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node }}
- name: ⚙️ Install dependencies
run: npm install
- name: 🔍 Run tests
run: npm test
- name: 🔨 Build the project
run: npm run build
Loading