Incompatible licenses?

[gspr]

Hera's licensing terms seem incompatible with those of the bundled copy of PHAT (GPL).

[gspr]

Ping @anigmetov .

[anigmetov]

Sorry, totally forgot about that at the time. The solution we came up with was to keep bottleneck and Wasserstein parts under BSD and additionally apply GPL to the whole library. So the matching distance part is under GPL, because it's required by PHAT, and the rest of Hera can be used with either of the licenses. Hope that resolves the issue.

[gspr]

On 4 December 2024 21:23:26 CET, Arnur Nigmetov ***@***.***> wrote: Sorry, totally forgot about that at the time. The solution we came up with was to keep bottleneck and Wasserstein parts under BSD and additionally apply GPL to the whole library. So the matching distance part is under GPL, because it's required by PHAT, and the rest of Hera can be used with either of the licenses. Hope that resolves the issue.

Well, ok, but that's not what the licensing documentation says at all. It just says BSD. Even the matching part just says see the license file in the root, which says BSD. Clearly stipulating *exactly* which files are under which license becomes even more important in cases like this where different files are under different incompatible license.

[anigmetov]

See the last commit, I updated the readme specifying paths.

…

On Wed, Dec 4, 2024, 22:14 gspr ***@***.***> wrote: On 4 December 2024 21:23:26 CET, Arnur Nigmetov ***@***.***> wrote: >Sorry, totally forgot about that at the time. The solution we came up with was to keep bottleneck and Wasserstein parts under BSD and additionally apply GPL to the whole library. So the matching distance part is under GPL, because it's required by PHAT, and the rest of Hera can be used with either of the licenses. Hope that resolves the issue. > Well, ok, but that's not what the licensing documentation says at all. It just says BSD. Even the matching part just says see the license file in the root, which says BSD. Clearly stipulating *exactly* which files are under which license becomes even more important in cases like this where different files are under different incompatible license. — Reply to this email directly, view it on GitHub <#13 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALP2ZHRP6ZBWNFRADPARPL2D7VNPAVCNFSM6AAAAABTA7IUNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJZGI3TEMBTHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[gspr]

Ah, my bad. I got confused by the paragraph in the README. It, too, needs updating. -- Sent from my Android device with K-9 Mail. Please excuse my brevity.