Skip to content

Commit c73ecc2

Browse files
author
jspdown
committed
Pre-release 0.0.3: Updated version on Bower
1 parent 0d1cac9 commit c73ecc2

File tree

7 files changed

+43
-51
lines changed

7 files changed

+43
-51
lines changed

Changelog.md

+23-5
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,26 @@
1-
0.0.2 [WiP]
1+
0.0.3 [Released]
22
=============================
3-
* Added Wizard directive
4-
* fixes to dropdown to update model, and allow for {{variables}} as title
5-
* code clean up and grunt task optimization
3+
4+
* Animated modal
5+
* Destroy listener was being called to destroy an accordion in the dropdown module
6+
* Corrected spelling in accordion README.md
7+
* Use semantic ui classes instead of inline style in the sidebar module
8+
9+
10+
0.0.2 [Released]
11+
=============================
12+
13+
* Added wizard directive
14+
* Fixes to dropdown to update model, and allow for {{variables}} as title
15+
* Code clean up and grunt task optimization
16+
* Fixed scope issue with accordion
17+
* Updated modal to use ng-class
18+
* Updated accordion to use ng-class
19+
* Updated sidebar to use semantic-ui javascript functions
20+
* Updated README.md
21+
* Corrected spelling in rating module
22+
* Corrected opening problem for the dropdown
23+
624

725
0.0.1 [Released]
826
=============================
@@ -18,4 +36,4 @@
1836
* `modal` - initial release;
1937
* `popup` - initial release;
2038
* `raiting` - initial release;
21-
* `sidebar` - initial release.
39+
* `sidebar` - initial release.

Contributors.md

+3
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,6 @@ Contributors:
77
* [cgroner](https://github.com/cgroner)
88
* [solcates](https://github.com/solcates)
99
* [jspdown](https://github.com/jspdown)
10+
* [xblaster](https://github.com/xblaster)
11+
* [frankt117](https://github.com/frankt117)
12+
* [tombee](https://github.com/tombee)

bower.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "angular-semantic-ui",
33
"description": "Angular - AngularJS directives for Semantic UI.",
4-
"version": "0.0.2",
4+
"version": "0.0.3",
55
"keywords": [
66
"angular",
77
"ui"

dist/angular-semantic-ui.js

+14-15
Original file line numberDiff line numberDiff line change
@@ -275,11 +275,6 @@ angular.module('angularify.semantic.dropdown', [])
275275

276276
this.add_item = function (scope) {
277277
$scope.items.push(scope);
278-
279-
scope.$on('$destroy', function(event) {
280-
this.remove_accordion(scope);
281-
});
282-
283278
return $scope.items;
284279
};
285280

@@ -407,18 +402,22 @@ angular.module('angularify.semantic.modal', [])
407402

408403
.directive('modal', function () {
409404
return {
410-
restrict: "E",
405+
restrict: 'E',
411406
replace: true,
412407
transclude: true,
413-
scope: {
414-
model: '=ngModel'
415-
},
416-
template: "<div class=\"ui dimmer page\" ng-class=\"{ active: model }\">" +
417-
"<div class=\"ui test modal transition visible\" style=\"margin-top: -189px;\" ng-transclude>" +
418-
"</div>" +
419-
"</div>",
420-
link: function (scope, element, attrs) {
421-
408+
require: 'ngModel',
409+
template: '<div class="ui modal" ng-transclude></div>',
410+
link: function (scope, element, attrs, ngModel) {
411+
element.modal({
412+
onHide: function () {
413+
ngModel.$setViewValue(false);
414+
}
415+
});
416+
scope.$watch(function () {
417+
return ngModel.$modelValue;
418+
}, function (modelValue){
419+
element.modal(modelValue ? 'show' : 'hide');
420+
});
422421
}
423422
}
424423
});

dist/angular-semantic-ui.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "angular-semantic-ui",
33
"description": "Angular - AngularJS directives for Semantic UI.",
4-
"version": "0.0.2",
4+
"version": "0.0.3",
55
"keywords": [
66
"angular",
77
"ui",

src/sidebar/test/sidebar.spec.js

-28
Original file line numberDiff line numberDiff line change
@@ -6,32 +6,4 @@ describe('sidebar', function () {
66
beforeEach(inject(function ($rootScope) {
77
$scope = $rootScope;
88
}));
9-
10-
describe('controller', function () {
11-
var ctrl, $element, $attrs;
12-
13-
beforeEach(inject(function($controller) {
14-
$attrs = {}; $element = {};
15-
ctrl = $controller('SideBarController', { $scope: $scope });
16-
}));
17-
18-
describe('add_sidebar_item', function() {
19-
it("SideBarController add_sidebar_item test", function(){
20-
var acc1, acc2;
21-
ctrl.add_sidebar_items(acc1 = $scope.$new());
22-
ctrl.add_sidebar_items(acc2 = $scope.$new());
23-
expect($scope.side_bar_items.length).toBe(2);
24-
});
25-
});
26-
27-
describe('remove_side_bar_item', function(){
28-
it("SideBarController remove_side_bar test", function(){
29-
var acc1, acc2;
30-
ctrl.add_sidebar_items(acc1 = $scope.$new());
31-
ctrl.add_sidebar_items(acc2 = $scope.$new());
32-
ctrl.remove_side_bar_item(acc2);
33-
expect($scope.side_bar_items.length).toBe(1);
34-
})
35-
});
36-
});
379
});

0 commit comments

Comments
 (0)