fix(language-service): Do not provide element completions in end tag #60616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: language-service
atscott
force-pushed
the
completions
branch
2 times, most recently
from
14307fe to
5e38ab3
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
devversion
approved these changes
Mar 28, 2025
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Element completions should not be provided when the position is in the end tag or between the start and end tags. fixes angular/vscode-ng-language-service#2157
atscott
added
action: merge
|
This PR was merged into the repository by commit a22b13f. The changes were merged into the following branches: main, 19.2.x |
atscott
added a commit
that referenced
this pull request
Apr 3, 2025
…60616) Element completions should not be provided when the position is in the end tag or between the start and end tags. fixes angular/vscode-ng-language-service#2157 PR Close #60616
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Element completions should not be provided when the position is in the end tag or between the start and end tags.
fixes angular/vscode-ng-language-service#2157