Skip to content
This repository was archived by the owner on Nov 22, 2024. It is now read-only.

Commit 52e7505

Browse files
committed
build: remove unused bazel macros
1 parent 914a6c6 commit 52e7505

File tree

3 files changed

+34
-489
lines changed

3 files changed

+34
-489
lines changed

package.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@
6262
"@bazel/hide-bazel-files": "~1.6.0",
6363
"@bazel/ibazel": "^0.13.0",
6464
"@bazel/jasmine": "~1.6.0",
65-
"@bazel/karma": "~1.6.0",
6665
"@bazel/typescript": "~1.6.0",
6766
"@hapi/hapi": "^18.4.0",
6867
"@schematics/angular": "^10.0.0-next.6",
@@ -81,11 +80,6 @@
8180
"guess-parser": "^0.4.12",
8281
"http-proxy-middleware": "^1.0.0",
8382
"jasmine-core": "^3.0.0",
84-
"karma": "^5.0.0",
85-
"karma-chrome-launcher": "^3.0.0",
86-
"karma-jasmine": "^3.0.0",
87-
"karma-sourcemap-loader": "^0.3.7",
88-
"karma-typescript": "^5.0.0",
8983
"minimatch": "^3.0.4",
9084
"node-fetch": "^2.2.0",
9185
"protractor": "7.0.0",

tools/defaults.bzl

Lines changed: 4 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ load(
77
"@npm_bazel_typescript//:index.bzl",
88
_ts_library = "ts_library",
99
)
10-
load("@npm_bazel_karma//:index.bzl", _karma_web_test_suite = "karma_web_test_suite")
1110

1211
DEFAULT_TSCONFIG_BUILD = "//modules:bazel-tsconfig-build.json"
1312
DEFAULT_TSCONFIG_TEST = "//modules:bazel-tsconfig-test"
@@ -84,15 +83,6 @@ GLOBALS = {
8483
"tslib": "tslib",
8584
}
8685

87-
# TODO(Toxicable): when a better api for defaults is avilable use that instead of these macros
88-
def ts_test_library(deps = [], tsconfig = None, **kwargs):
89-
local_deps = deps
90-
ts_library(
91-
testonly = 1,
92-
deps = local_deps,
93-
**kwargs
94-
)
95-
9686
def ng_module(name, tsconfig = None, testonly = False, deps = [], bundle_dts = True, **kwargs):
9787
deps = deps + ["@npm//tslib", "@npm//@types/node"]
9888
if not tsconfig:
@@ -127,8 +117,12 @@ def ng_test_library(deps = [], tsconfig = None, **kwargs):
127117
"@npm//@types/jasmine",
128118
] + deps
129119

120+
if not tsconfig:
121+
tsconfig = _getDefaultTsConfig(1)
122+
130123
ts_library(
131124
testonly = 1,
125+
tsconfig = tsconfig,
132126
deps = local_deps,
133127
**kwargs
134128
)
@@ -144,16 +138,3 @@ def pkg_npm(name, substitutions = {}, **kwargs):
144138
substitutions = dict(substitutions, **PKG_GROUP_REPLACEMENTS),
145139
**kwargs
146140
)
147-
148-
def ng_web_test_suite(deps = [], srcs = [], **kwargs):
149-
_karma_web_test_suite(
150-
# Required for running the compiled ng modules that use TypeScript import helpers.
151-
srcs = ["@npm//:node_modules/tslib/tslib.js"] + srcs,
152-
# Depend on our custom test initialization script. This needs to be the first dependency.
153-
deps = ["//test:angular_test_init"] + deps,
154-
bootstrap = [
155-
"@npm//:node_modules/zone.js/dist/zone-testing-bundle.js",
156-
"@npm//:node_modules/reflect-metadata/Reflect.js",
157-
],
158-
**kwargs
159-
)

0 commit comments

Comments
 (0)