Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release tool]: run nvm gracefully to ensure caretaker uses correct node version for publish branch #312

Open
devversion opened this issue Nov 19, 2021 · 0 comments

Comments

@devversion
Copy link
Member

The merge tool will currently check out other branches, such as patch, LTS etc. For that the node versions could be different and breaking. This currently results in some inconvenient Yarn install engines error mid-publishing in a way where recovering is rather cumbersome..

We should run nvm automatically, gracefully as not everbody might have it. If it fails, we print a warning and proceed running the Yarn install. That one could still fail in such cases, but this is expected then.

Note: We have considered using the Bazel-managed Node version (that would be ideal).. but we cannot let Bazel install the node modules as Bazel itself is actually made available through the @bazel/bazelisk package (caretaker might not have the proper Bazel version globally installed; if at all)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant