Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import MatDatepickerModule with "Redux DevTools" chrome extension causes an error and app crash. #9786

Closed
ghost opened this issue Feb 5, 2018 · 4 comments
Labels
needs: clarification The issue does not contain enough information for the team to determine if it is a real bug

Comments

@ghost
Copy link

ghost commented Feb 5, 2018

Bug, feature request, or proposal:

Importing MatDatepickerModule when using ngrx StoreDevTools with "Redux DevTools" chrome extension causes an error.

Very similar behavior to what is described here: ngrx/platform#61

What is the expected behavior?

No error && crash.

What is the current behavior?

core.js:1440 ERROR Error: Uncaught (in promise): TypeError: toISOString is not a function
TypeError: toISOString is not a function
    at String.toJSON (<anonymous>)
    at Object.eval (_ctx.js:18)
    at derez (<anonymous>:2:5451)
    at derez (<anonymous>:2:6072)
    at derez (<anonymous>:2:6072)
    at derez (<anonymous>:2:6072)
    at derez (<anonymous>:2:5890)
    at derez (<anonymous>:2:6072)
    at derez (<anonymous>:2:6072)
    at derez (<anonymous>:2:6072)
    at String.toJSON (<anonymous>)
    at Object.eval (_ctx.js:18)
    at derez (<anonymous>:2:5451)
    at derez (<anonymous>:2:6072)
    at derez (<anonymous>:2:6072)
    at derez (<anonymous>:2:6072)
    at derez (<anonymous>:2:5890)
    at derez (<anonymous>:2:6072)
    at derez (<anonymous>:2:6072)
    at derez (<anonymous>:2:6072)
    at resolvePromise (zone.js:809)
    at resolvePromise (zone.js:775)
    at eval (zone.js:858)
    at ZoneDelegate.invokeTask (zone.js:421)
    at Object.onInvokeTask (core.js:4724)
    at ZoneDelegate.invokeTask (zone.js:420)
    at Zone.runTask (zone.js:188)
    at drainMicroTaskQueue (zone.js:595)
    at <anonymous>

What are the steps to reproduce?

  • import MatDatepickerModule
  • import StoreDevtoolsModule (from ngrx/store-devtools)
  • "Redux DevTools" chrome extension

What is the use-case or motivation for changing an existing behavior?

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

"@angular/common": "^5.2.0",
"@angular/material": "^5.1.1",
"typescript": "~2.5.3",

OS: OSX
Browser: Chrome Version 63.0.3239.132

Is there anything else we should know?

Check discussion here: ngrx/platform#61

Error goes away if you remove/disable a single of the following:

  • imports: [ MatDatepickerModule]
  • imports: [StoreDevtoolsModule]
  • "Redux DevTools" chrome extension
  • polyfill: import 'core-js/es6/date';
@jelbourn
Copy link
Member

Are you saying this only happens with a certain Chrome extension enabled?

@jelbourn jelbourn added the needs: clarification The issue does not contain enough information for the team to determine if it is a real bug label Feb 13, 2018
@ghost
Copy link
Author

ghost commented Feb 14, 2018

@jelbourn yes, its an extension to debug Redux actions, so it has some interaction with ngrx's StoreDevtoolsModule which, as described, also needs to be imported to trigger this error.

@jelbourn
Copy link
Member

If things work without the extension and then break with the extension, I'd say the issue is probably in the extension and out of the scope of Angular Material.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: clarification The issue does not contain enough information for the team to determine if it is a real bug
Projects
None yet
Development

No branches or pull requests

1 participant