Skip to content

Commit c19fc7b

Browse files
committed
docs: the example --base-href for a non-custom domain should be terminated with a slash.
fixes #62 Many thanks to @TrevorKarjanis
1 parent 3612d05 commit c19fc7b

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -132,10 +132,10 @@ ng deploy --repo=https://github.com/<username>/<repositoryname>.git --name="Your
132132
* Default: `undefined` (string)
133133
* Example:
134134
* `ng deploy` -- `<base href="/">` remains unchanged in your `index.html`
135-
* `ng deploy --base-href=/the-repositoryname` -- `<base href="/the-repositoryname">` is added to your `index.html`
135+
* `ng deploy --base-href=/the-repositoryname/` -- `<base href="/the-repositoryname/">` is added to your `index.html`
136136

137137
Specifies the base URL for the application being built.
138-
Same as `ng build --base-href=XXX`
138+
Same as `ng build --base-href=/XXX/`
139139

140140
**ℹ️ Please read the next lines carefully, or you will get 404 errors in case of a wrong configuration!**
141141

@@ -146,7 +146,7 @@ If you don't want to use an own domain, then your later URL of your hosted Angul
146146
In this case you have to adjust the `--base-href` accordingly:
147147

148148
```sh
149-
ng deploy --base-href=/the-repositoryname
149+
ng deploy --base-href=/the-repositoryname/
150150
```
151151

152152
##### B) You want to use a custom domain

src/deploy/schema.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"properties": {
66
"baseHref": {
77
"type": "string",
8-
"description": "Base url for the application being built. Same as `ng build --base-href=XXX`."
8+
"description": "Base url for the application being built. Same as `ng build --base-href=/XXX/`."
99
},
1010
"configuration": {
1111
"type": "string",

src/package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "angular-cli-ghpages",
3-
"version": "0.6.0-rc.1",
3+
"version": "0.6.0-rc.2",
44
"description": "Deployment from the Angular CLI to GitHub pages (or any other branch on any other remote)",
55
"main": "index.js",
66
"bin": {

0 commit comments

Comments
 (0)