Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCM updated their api. #15

Open
Almeonamy opened this issue Dec 26, 2017 · 11 comments
Open

FCM updated their api. #15

Almeonamy opened this issue Dec 26, 2017 · 11 comments

Comments

@Almeonamy
Copy link

FCM updated their api. Do you plan to update your library for new api version? Now default sounds are not supported in iOS by FCM.Net.
https://firebase.google.com/docs/reference/fcm/rest/v1/projects.messages

@angelobelchior
Copy link
Owner

Yes, soon I will make a new version available. Feel free to submit a Pull Request :)

@rburnham52
Copy link

What exactly did they change? based on the docs it looks like Notification only has Title / Body but FCM's notification contains additional properties like Badge. Is this what has changed? Looks like they added platform specific objects at the root as well.

Does this mean badge updates won't work?

@rburnham52
Copy link

Ah i see, FCM.net is using Legacy format. https://firebase.google.com/docs/cloud-messaging/http-server-ref

@rburnham52
Copy link

I started working on this and it seems like a bigger change that i thought. The V1 is an entirely new endpoint that requires the ProjectId for the Url and authenticates using OAuth 2.0.

It's looking like some pretty big change to sender that i was hoping not to do. At the moment i'm just creating a new V1 namespace, that way anyone using the old format should still work. But there seems to be enough changes to question, should this be a separate package?

@martinhey
Copy link

In my opinion the legacy implementation should be a separate package, as there are too many changes and I think it would be hard to maintain both api versions in the same library.
However, whatever will be the final decision: I'm currently looking for a good option to send fcm messages using the new API version as I need the separation of values for iOS and Android. So could help to implement the new api version here rather than writing an own implementation. So if you already started implementation, maybe I could contribute.

@angelobelchior
Copy link
Owner

@martinhey I will begin soon to change the api to use the new features. Feel free to contribute :)

@martinhey
Copy link

of course... let's keep in touch and define subtasks

@markalanevans
Copy link

@martinhey so @angelobelchior i'm just starting out, but does this package not support V1? Should I not consider this Package? Perhaps update the Readme.md with the details.

@ejdrian313
Copy link

is time_to_live change to ttl? because i can't set it in my projects now

@ofcerci4826
Copy link

@angelobelchior What is the latest situation on this subject?

@rburnham52
Copy link

@ofcerci4826 We ended up using FCMSharp instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants