Skip to content

Commit 5f741bb

Browse files
icbakericbaker
committed
Add lint baseline for spurious API-level warnings
The API 32 SDK has incorrect versioning metadata for Spatializer. It reports the whole class has only been present since API 33 (which is surely impossible given it's present in the API 32 SDK): https://issuetracker.google.com/234009300 The metadata seems to be correct in the API 33 SDK, so this baseline will no longer be needed when we bump to `compileSdkVersion = 33`.
1 parent 68e5612 commit 5f741bb

File tree

2 files changed

+129
-0
lines changed

2 files changed

+129
-0
lines changed

‎libraries/exoplayer/build.gradle

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ android {
2828
}
2929
}
3030

31+
lint {
32+
baseline = file("lint-baseline.xml")
33+
}
34+
3135
sourceSets {
3236
androidTest.assets.srcDir '../test_data/src/test/assets'
3337
test.assets.srcDir '../test_data/src/test/assets/'

‎libraries/exoplayer/lint-baseline.xml

Lines changed: 125 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,125 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<issues format="6" by="lint 7.2.1" type="baseline" client="gradle" dependencies="false" name="AGP (7.2.1)" variant="all" version="7.2.1">
3+
4+
<issue
5+
id="NewApi"
6+
message="Call requires API level 33 (current min is 32): `android.media.AudioManager#getSpatializer`"
7+
errorLine1=" return audioManager == null ? null : new SpatializerWrapperV32(audioManager.getSpatializer());"
8+
errorLine2=" ~~~~~~~~~~~~~~">
9+
<location
10+
file="src/main/java/androidx/media3/exoplayer/trackselection/DefaultTrackSelector.java"
11+
line="3646"
12+
column="83"/>
13+
</issue>
14+
15+
<issue
16+
id="NewApi"
17+
message="Call requires API level 33 (current min is 32): `android.media.Spatializer#getImmersiveAudioLevel`"
18+
errorLine1=" spatializer.getImmersiveAudioLevel() != Spatializer.SPATIALIZER_IMMERSIVE_LEVEL_NONE;"
19+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
20+
<location
21+
file="src/main/java/androidx/media3/exoplayer/trackselection/DefaultTrackSelector.java"
22+
line="3652"
23+
column="23"/>
24+
</issue>
25+
26+
<issue
27+
id="NewApi"
28+
message="Cast to `OnSpatializerStateChangedListener` requires API level 33 (current min is 32)"
29+
errorLine1=" new Spatializer.OnSpatializerStateChangedListener() {"
30+
errorLine2=" ^">
31+
<location
32+
file="src/main/java/androidx/media3/exoplayer/trackselection/DefaultTrackSelector.java"
33+
line="3660"
34+
column="11"/>
35+
</issue>
36+
37+
<issue
38+
id="NewApi"
39+
message="Class requires API level 33 (current min is 32): `android.media.Spatializer.OnSpatializerStateChangedListener`"
40+
errorLine1=" new Spatializer.OnSpatializerStateChangedListener() {"
41+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
42+
<location
43+
file="src/main/java/androidx/media3/exoplayer/trackselection/DefaultTrackSelector.java"
44+
line="3660"
45+
column="15"/>
46+
</issue>
47+
48+
<issue
49+
id="NewApi"
50+
message="Call requires API level 33 (current min is 32): `android.media.Spatializer#addOnSpatializerStateChangedListener`"
51+
errorLine1=" spatializer.addOnSpatializerStateChangedListener(handler::post, listener);"
52+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
53+
<location
54+
file="src/main/java/androidx/media3/exoplayer/trackselection/DefaultTrackSelector.java"
55+
line="3672"
56+
column="19"/>
57+
</issue>
58+
59+
<issue
60+
id="NewApi"
61+
message="Call requires API level 33 (current min is 32): `android.media.Spatializer#isAvailable`"
62+
errorLine1=" return spatializer.isAvailable();"
63+
errorLine2=" ~~~~~~~~~~~">
64+
<location
65+
file="src/main/java/androidx/media3/exoplayer/trackselection/DefaultTrackSelector.java"
66+
line="3680"
67+
column="26"/>
68+
</issue>
69+
70+
<issue
71+
id="NewApi"
72+
message="Call requires API level 33 (current min is 32): `android.media.Spatializer#isEnabled`"
73+
errorLine1=" return spatializer.isEnabled();"
74+
errorLine2=" ~~~~~~~~~">
75+
<location
76+
file="src/main/java/androidx/media3/exoplayer/trackselection/DefaultTrackSelector.java"
77+
line="3684"
78+
column="26"/>
79+
</issue>
80+
81+
<issue
82+
id="NewApi"
83+
message="Call requires API level 33 (current min is 32): `android.media.Spatializer#canBeSpatialized`"
84+
errorLine1=" return spatializer.canBeSpatialized("
85+
errorLine2=" ~~~~~~~~~~~~~~~~">
86+
<location
87+
file="src/main/java/androidx/media3/exoplayer/trackselection/DefaultTrackSelector.java"
88+
line="3702"
89+
column="26"/>
90+
</issue>
91+
92+
<issue
93+
id="NewApi"
94+
message="Call requires API level 33 (current min is 32): `android.media.Spatializer#removeOnSpatializerStateChangedListener`"
95+
errorLine1=" spatializer.removeOnSpatializerStateChangedListener(listener);"
96+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
97+
<location
98+
file="src/main/java/androidx/media3/exoplayer/trackselection/DefaultTrackSelector.java"
99+
line="3710"
100+
column="19"/>
101+
</issue>
102+
103+
<issue
104+
id="Override"
105+
message="This method is not overriding anything with the current build target, but will in API level 33 (current target is 32): `null#onSpatializerEnabledChanged`"
106+
errorLine1=" public void onSpatializerEnabledChanged(Spatializer spatializer, boolean enabled) {"
107+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~">
108+
<location
109+
file="src/main/java/androidx/media3/exoplayer/trackselection/DefaultTrackSelector.java"
110+
line="3662"
111+
column="25"/>
112+
</issue>
113+
114+
<issue
115+
id="Override"
116+
message="This method is not overriding anything with the current build target, but will in API level 33 (current target is 32): `null#onSpatializerAvailableChanged`"
117+
errorLine1=" public void onSpatializerAvailableChanged(Spatializer spatializer, boolean available) {"
118+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
119+
<location
120+
file="src/main/java/androidx/media3/exoplayer/trackselection/DefaultTrackSelector.java"
121+
line="3667"
122+
column="25"/>
123+
</issue>
124+
125+
</issues>

0 commit comments

Comments
 (0)