-
Notifications
You must be signed in to change notification settings - Fork 4k
Refactor network module #1949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Refactor network module #1949
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@googlebot I signed it! |
2 similar comments
|
@googlebot I signed it! |
|
@googlebot I signed it! |
6b09cf6 to
2d76114
Compare
|
In the previous codebase, it was easy to see the backend API schema in a single file, whereas now it's split across 2 files. Since we have no plans to change/extend the backend API, I'm struggling to understand the benefit of this change. |
Thanks for the thoughtful question! |
What I have done and why
This refactor was inspired by using the NIA project as a base project. It improves maintainability and makes the codebase easier to extend when working with multiple API methods.
Testing
./gradlew testDemoDebuglocally; all tests passed../gradlew --init-script gradle/init.gradle.kts spotlessApply.Related issues