diff --git a/apis/v1/jaeger_types.go b/apis/v1/jaeger_types.go index 7c1ce8d32..223e45c00 100644 --- a/apis/v1/jaeger_types.go +++ b/apis/v1/jaeger_types.go @@ -681,6 +681,9 @@ type JaegerEsIndexCleanerSpec struct { // +optional JaegerCommonSpec `json:",inline,omitempty"` + + // +optional + PriorityClassName string `json:"priorityClassName,omitempty"` } // JaegerEsRolloverSpec holds the options related to es-rollover diff --git a/bundle/manifests/jaegertracing.io_jaegers.yaml b/bundle/manifests/jaegertracing.io_jaegers.yaml index 50212d9c1..c23cca6df 100644 --- a/bundle/manifests/jaegertracing.io_jaegers.yaml +++ b/bundle/manifests/jaegertracing.io_jaegers.yaml @@ -10030,6 +10030,8 @@ spec: type: object numberOfDays: type: integer + priorityClassName: + type: string resources: nullable: true properties: diff --git a/config/crd/bases/jaegertracing.io_jaegers.yaml b/config/crd/bases/jaegertracing.io_jaegers.yaml index 69e3644e1..99acaff32 100644 --- a/config/crd/bases/jaegertracing.io_jaegers.yaml +++ b/config/crd/bases/jaegertracing.io_jaegers.yaml @@ -10027,6 +10027,8 @@ spec: type: object numberOfDays: type: integer + priorityClassName: + type: string resources: nullable: true properties: diff --git a/docs/api.md b/docs/api.md index 47170844b..a77956edf 100644 --- a/docs/api.md +++ b/docs/api.md @@ -37720,6 +37720,13 @@ Resource Types:
false + + priorityClassName + string + +
+ + false resources object diff --git a/pkg/cronjob/es_index_cleaner.go b/pkg/cronjob/es_index_cleaner.go index 389b35ec8..aeb3b74dc 100644 --- a/pkg/cronjob/es_index_cleaner.go +++ b/pkg/cronjob/es_index_cleaner.go @@ -45,6 +45,11 @@ func CreateEsIndexCleaner(jaeger *v1.Jaeger) *batchv1beta1.CronJob { ca.Update(jaeger, commonSpec) + priorityClassName := "" + if jaeger.Spec.Storage.EsIndexCleaner.PriorityClassName != "" { + priorityClassName = jaeger.Spec.Storage.EsIndexCleaner.PriorityClassName + } + return &batchv1beta1.CronJob{ ObjectMeta: metav1.ObjectMeta{ Name: name, @@ -88,6 +93,7 @@ func CreateEsIndexCleaner(jaeger *v1.Jaeger) *batchv1beta1.CronJob { SecurityContext: commonSpec.SecurityContext, ServiceAccountName: account.JaegerServiceAccountFor(jaeger, account.EsIndexCleanerComponent), Volumes: commonSpec.Volumes, + PriorityClassName: priorityClassName, }, ObjectMeta: metav1.ObjectMeta{ Labels: commonSpec.Labels, diff --git a/pkg/cronjob/es_index_cleaner_test.go b/pkg/cronjob/es_index_cleaner_test.go index 6764c2d74..2fff9853a 100644 --- a/pkg/cronjob/es_index_cleaner_test.go +++ b/pkg/cronjob/es_index_cleaner_test.go @@ -232,3 +232,12 @@ func TestCustomEsIndexCleanerImage(t *testing.T) { assert.Empty(t, jaeger.Spec.Storage.EsIndexCleaner.Image) assert.Equal(t, "org/custom-es-index-cleaner-image:"+version.Get().Jaeger, cjob.Spec.JobTemplate.Spec.Template.Spec.Containers[0].Image) } + +// Test Case for PriorityClassName +func TestPriorityClassName(t *testing.T) { + jaeger := v1.NewJaeger(types.NamespacedName{Name: "TestPriorityClassName"}) + + priorityClassNameVal := "" + + assert.Equal(t, priorityClassNameVal, jaeger.Spec.Storage.EsIndexCleaner.PriorityClassName) +} diff --git a/pkg/deployment/query.go b/pkg/deployment/query.go index 0d55de58f..a75c1104e 100644 --- a/pkg/deployment/query.go +++ b/pkg/deployment/query.go @@ -86,10 +86,7 @@ func (q *Query) Get() *appsv1.Deployment { // see https://github.com/jaegertracing/jaeger-operator/issues/334 sort.Strings(options) - priorityClassName := "" - if q.jaeger.Spec.Query.PriorityClassName != "" { - priorityClassName = q.jaeger.Spec.Query.PriorityClassName - } + priorityClassName := q.jaeger.Spec.Query.PriorityClassName strategy := appsv1.DeploymentStrategy{ Type: appsv1.RecreateDeploymentStrategyType,