Skip to content

Commit d2529c2

Browse files
authored
Merge pull request #150 from anam-org/fix/force-in-memory-keyv
fix: prevent adapter warnings for keyv when using ably
2 parents b568ade + ec2fc66 commit d2529c2

File tree

4 files changed

+26
-7
lines changed

4 files changed

+26
-7
lines changed

package-lock.json

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@
6666
},
6767
"dependencies": {
6868
"ably": "^2.9.0",
69-
"buffer": "^6.0.3"
69+
"buffer": "^6.0.3",
70+
"keyv": "^4.5.4"
7071
}
7172
}

src/modules/SignallingClient.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import * as Ably from 'ably';
1+
import { Realtime, RealtimeChannel, Message as AblyMessage } from 'ably';
22
import { InternalEventEmitter, PublicEventEmitter } from '.';
33
import {
44
AnamEvent,
@@ -17,8 +17,8 @@ export class SignallingClient {
1717
private sessionId: string;
1818
private ablyToken: string;
1919
private channelName: string;
20-
private realtime: Ably.Realtime | null = null;
21-
private channel: Ably.RealtimeChannel | null = null;
20+
private realtime: Realtime | null = null;
21+
private channel: RealtimeChannel | null = null;
2222
private stopSignal = false;
2323

2424
constructor(
@@ -62,7 +62,7 @@ export class SignallingClient {
6262
}
6363

6464
// Initialize Ably Realtime client with echo disabled
65-
this.realtime = new Ably.Realtime({
65+
this.realtime = new Realtime({
6666
token: this.ablyToken,
6767
echoMessages: false,
6868
disconnectedRetryTimeout: 1000, // Retry after 1 second
@@ -192,7 +192,7 @@ export class SignallingClient {
192192
);
193193
}
194194

195-
private onMessage(message: Ably.Message) {
195+
private onMessage(message: AblyMessage) {
196196
// Extract the SignalMessage from Ably message data
197197
let signalMessage: SignalMessage = message.data;
198198
// Messages coming back from the server may have an encoded payload, convert it to unencoded for cosumption elsewhere in the SDK

webpack.config.js

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,28 @@ module.exports = {
2626
extensions: ['.ts', '.js', '.json'],
2727
fallback: {
2828
buffer: require.resolve('buffer/'),
29+
fs: false,
30+
path: false,
31+
os: false,
32+
},
33+
alias: {
34+
'@keyv/redis': false,
35+
'@keyv/mongo': false,
36+
'@keyv/sqlite': false,
37+
'@keyv/postgres': false,
38+
'@keyv/mysql': false,
39+
'@keyv/etcd': false,
40+
'@keyv/offline': false,
41+
'@keyv/tiered': false,
2942
},
3043
},
3144
plugins: [
3245
new webpack.ProvidePlugin({
3346
Buffer: ['buffer', 'Buffer'],
3447
}),
48+
new webpack.IgnorePlugin({
49+
resourceRegExp:
50+
/^@keyv\/(redis|mongo|sqlite|postgres|mysql|etcd|offline|tiered)$/,
51+
}),
3552
],
3653
};

0 commit comments

Comments
 (0)