Merge pull request #109 from anam-org/fix/connection-established-metric

fix: send metrics even with no event listeners

Author: ao-anam

src/lib/ClientError.ts

@@ -1,4 +1,5 @@
 import { CLIENT_METADATA } from './constants';
+
 export enum ErrorCode {
   CLIENT_ERROR_CODE_USAGE_LIMIT_REACHED = 'CLIENT_ERROR_CODE_USAGE_LIMIT_REACHED',
   CLIENT_ERROR_CODE_VALIDATION_ERROR = 'CLIENT_ERROR_CODE_VALIDATION_ERROR',
@@ -14,6 +15,12 @@ export enum ErrorCode {
 export const DEFAULT_ANAM_METRICS_BASE_URL = 'https://api.anam.ai';
 export const DEFAULT_ANAM_API_VERSION = '/v1';
 
+export enum ClientMetricMeasurement {
+  CLIENT_METRIC_MEASUREMENT_ERROR = 'client_error',
+  CLIENT_METRIC_MEASUREMENT_CONNECTION_CLOSED = 'client_connection_closed',
+  CLIENT_METRIC_MEASUREMENT_CONNECTION_ESTABLISHED = 'client_connection_established',
+}
+
 let anamCurrentBaseUrl = DEFAULT_ANAM_METRICS_BASE_URL;
 let anamCurrentApiVersion = DEFAULT_ANAM_API_VERSION;
 
@@ -94,9 +101,13 @@ export class ClientError extends Error {
     Object.setPrototypeOf(this, ClientError.prototype);
 
     // Send error metric when error is created
-    sendErrorMetric('client_error', code, {
-      details,
-      statusCode,
-    });
+    sendErrorMetric(
+      ClientMetricMeasurement.CLIENT_METRIC_MEASUREMENT_ERROR,
+      code,
+      {
+        details,
+        statusCode,
+      },
+    );
   }
 }

src/modules/PublicEventEmitter.ts

@@ -1,4 +1,4 @@
-import { sendErrorMetric } from '../lib/ClientError';
+import { ClientMetricMeasurement, sendErrorMetric } from '../lib/ClientError';
 import { AnamEvent, EventCallbacks } from '../types';
 
 export class PublicEventEmitter {
@@ -32,12 +32,22 @@ export class PublicEventEmitter {
     event: K,
     ...args: EventCallbacks[K] extends (...args: infer P) => any ? P : never
   ): void {
-    if (!this.listeners[event]) return;
+    if (event === AnamEvent.CONNECTION_ESTABLISHED) {
+      sendErrorMetric(
+        ClientMetricMeasurement.CLIENT_METRIC_MEASUREMENT_CONNECTION_ESTABLISHED,
+        '1',
+      );
+    }
 
     if (event === AnamEvent.CONNECTION_CLOSED) {
-      sendErrorMetric('client_connection_closed', args[0] as string);
+      sendErrorMetric(
+        ClientMetricMeasurement.CLIENT_METRIC_MEASUREMENT_CONNECTION_CLOSED,
+        args[0] as string,
+      );
     }
 
+    if (!this.listeners[event]) return;
+
     (this.listeners[event] as Set<EventCallbacks[K]>).forEach((callback) => {
       (callback as (...args: any[]) => void)(...args);
     });