iio: frequency: adf4030: fix possible uninitialized 'ret'

In adf4030_chan_dir_set(), every time 'initial' is false, 'ret' was being
used uninitialized because we're ignoring the return value from
regmap_update_bits(). Make sure we don't!

Fixes: 54bbd40 ("iio: frequency: support the adf4030 Synchronizer")
Signed-off-by: Nuno Sá <[email protected]>

Author: nunojsa

drivers/iio/frequency/adf4030.c

@@ -334,13 +334,13 @@ static int adf4030_chan_dir_set(const struct adf4030_state *st,
 
 	/* EN_DRIVE */
 	if (chan->num > 7)
-		regmap_update_bits(st->regmap, ADF4030_REG(0x13),
-				   BIT(chan->num - 8),
-				   chan->channel_output_en ? BIT(chan->num - 8) : 0);
+		ret = regmap_update_bits(st->regmap, ADF4030_REG(0x13),
+					 BIT(chan->num - 8),
+					 chan->channel_output_en ? BIT(chan->num - 8) : 0);
 	else
-		regmap_update_bits(st->regmap, ADF4030_REG(0x12),
-				   BIT(chan->num),
-				   chan->channel_output_en ? BIT(chan->num) : 0);
+		ret = regmap_update_bits(st->regmap, ADF4030_REG(0x12),
+					 BIT(chan->num),
+					 chan->channel_output_en ? BIT(chan->num) : 0);
 	if (ret)
 		return ret;