Merge pull request #36 from amplitude/ie10_xdomain_request

pass response code in xdr callback

Author: djih

CHANGELOG.md

@@ -1,5 +1,7 @@
 ## Unreleased
 
+* Fix bug where response code is not passed to XDomainRequest callback (affects IE versions 10 and lower).
+
 ## 2.6.1 (November 6, 2015)
 
 * Localstorage is not persisted across subdomains, reverting cookie data migration and adding a reverse migration path for users already on 2.6.0.

amplitude.js

@@ -2261,8 +2261,18 @@ Request.prototype.send = function(callback) {
     var xdr = new window.XDomainRequest();
     xdr.open('POST', this.url, true);
     xdr.onload = function() {
-      callback(xdr.responseText);
+      callback(200, xdr.responseText);
     };
+    xdr.onerror = function () {
+      // status code not available from xdr, try string matching on responseText
+      if (xdr.responseText === 'Request Entity Too Large') {
+        callback(413, xdr.responseText);
+      } else {
+        callback(500, xdr.responseText);
+      }
+    };
+    xdr.ontimeout = function () {};
+    xdr.onprogress = function() {};
     xdr.send(querystring.stringify(this.data));
   } else {
     var xhr = new XMLHttpRequest();

amplitude.min.js

@@ -14,8 +14,18 @@ Request.prototype.send = function(callback) {
     var xdr = new window.XDomainRequest();
     xdr.open('POST', this.url, true);
     xdr.onload = function() {
-      callback(xdr.responseText);
+      callback(200, xdr.responseText);
     };
+    xdr.onerror = function () {
+      // status code not available from xdr, try string matching on responseText
+      if (xdr.responseText === 'Request Entity Too Large') {
+        callback(413, xdr.responseText);
+      } else {
+        callback(500, xdr.responseText);
+      }
+    };
+    xdr.ontimeout = function () {};
+    xdr.onprogress = function() {};
     xdr.send(querystring.stringify(this.data));
   } else {
     var xhr = new XMLHttpRequest();