Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research audio players #3

Open
amcquade opened this issue Mar 14, 2019 · 7 comments
Open

Research audio players #3

amcquade opened this issue Mar 14, 2019 · 7 comments
Labels
enhancement New feature or request help wanted Extra attention is needed up-for-grabs

Comments

@amcquade
Copy link
Owner

User should be able to play episodes from the feed listed on the feed. Suggestions can go below

@amcquade amcquade added enhancement New feature or request help wanted Extra attention is needed up-for-grabs labels Mar 14, 2019
@danielgrijalva
Copy link

It may be simple, but the <audio /> tag can be used for this.

@amcquade
Copy link
Owner Author

@danielgrijalva was looking at react-player the other day, havent had the time to play around with it.

@danielgrijalva
Copy link

@amcquade that looks way better! I can try to implement it if you want. Do you have any mock ups/design ideas on how to display the player?

@amcquade
Copy link
Owner Author

@danielgrijalva not really, although lately ive been thinking that the soundcloud player is something wed like to try to emulate. a player containing a list of episodes instead of creating players/elements for each episode

@danielgrijalva
Copy link

I see... like this?
image
That's much more user friendly 👌 I'll see what I can do.

@danielgrijalva
Copy link

danielgrijalva commented May 6, 2019

Hey @amcquade, sorry for the delay. Here's my progress so far:
Peek 2019-05-06 11-21

What do you think? The actual player is from react-player and I'm looking to change its CSS to make it look like this:

https://blackboxvision.github.io/mui-audio-player/?path=/story/muiaudioplayer--muiaudioplayer

Let me know your thoughts! 😃

@amcquade
Copy link
Owner Author

amcquade commented May 7, 2019

@danielgrijalva no worries, looks great ! my only suggestion being some kind of wrapping the list in some sort of container that enables scrolling for the list and not the whole page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed up-for-grabs
Projects
None yet
Development

No branches or pull requests

2 participants