Commit 987045d
fix(manifests): fix port name length and env patch conflict in deploy (#1613)
## Summary
- **`ambient-ui-proxy` port name** (16 chars) exceeds Kubernetes'
15-char limit, causing the Service and Deployment to fail validation.
Renamed to `oauthproxy` across `ambient-ui-oauth-patch.yaml`,
`ambient-ui-service-patch.yaml`, and `ambient-ui-route.yaml`.
- **`GITHUB_CALLBACK_URL` env conflict** —
`frontend-github-callback-patch.yaml` used JSON Patch `op: add` which
unconditionally appends to the env array. On re-apply against a live
cluster that already had the env var set, Kubernetes ended up with
`env[7]` containing both `value` and `valueFrom`, which it rejects.
Fixed by moving `GITHUB_CALLBACK_URL` into the base
`frontend-deployment.yaml` (strategic merge patch deduplication handles
updates cleanly) and removing the patch file entirely.
Fixes the failing `deploy-to-openshift` job run
[#26603107854](https://github.com/ambient-code/platform/actions/runs/26603107854).
## Test plan
- [ ] `kustomize build components/manifests/overlays/production`
produces no errors
- [ ] All port references to `ambient-ui-proxy` renamed to `oauthproxy`
(≤15 chars)
- [ ] `GITHUB_CALLBACK_URL` appears in frontend env with only
`valueFrom` (no `value` field)
- [ ] `deploy-to-openshift` job passes on merge to main
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>1 parent 4b1a0cf commit 987045d
6 files changed
Lines changed: 12 additions & 27 deletions
File tree
- components/manifests
- base/core
- overlays/production
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
47 | 53 | | |
48 | 54 | | |
49 | 55 | | |
| |||
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
| 53 | + | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
Lines changed: 0 additions & 14 deletions
This file was deleted.
Lines changed: 0 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | 71 | | |
79 | 72 | | |
80 | 73 | | |
| |||
0 commit comments