fix(manifests): fix port name length and env patch conflict in deploy

Port name 'ambient-ui-proxy' (16 chars) exceeds Kubernetes 15-char
limit, failing Service and Deployment validation. Rename to 'oauthproxy'
across the oauth patch, service patch, and route.

The frontend-github-callback-patch.yaml used JSON Patch op:add which
appended GITHUB_CALLBACK_URL unconditionally — on re-apply against the
live cluster this created a conflict where env[7] had both value and
valueFrom set, which Kubernetes rejects. Move GITHUB_CALLBACK_URL into
the base frontend-deployment.yaml so strategic merge patch deduplication
handles it cleanly, and remove the patch file.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: jsell-rh

components/manifests/base/core/frontend-deployment.yaml

@@ -44,6 +44,12 @@ spec:
               name: unleash-credentials
               key: client-api-token
               optional: true
+        - name: GITHUB_CALLBACK_URL
+          valueFrom:
+            configMapKeyRef:
+              name: frontend-config
+              key: github-callback-url
+              optional: true
         resources:
           requests:
             cpu: 100m

components/manifests/overlays/production/ambient-ui-oauth-patch.yaml

@@ -39,18 +39,18 @@ spec:
         - --skip-auth-regex=^/metrics
         ports:
         - containerPort: 8443
-          name: ambient-ui-proxy
+          name: oauthproxy
         livenessProbe:
           httpGet:
             path: /oauth/healthz
-            port: ambient-ui-proxy
+            port: oauthproxy
             scheme: HTTP
           initialDelaySeconds: 30
           periodSeconds: 5
         readinessProbe:
           httpGet:
             path: /oauth/healthz
-            port: ambient-ui-proxy
+            port: oauthproxy
             scheme: HTTP
           initialDelaySeconds: 5
           periodSeconds: 5

components/manifests/overlays/production/ambient-ui-route.yaml

@@ -10,7 +10,7 @@ spec:
     name: ambient-ui-service
     weight: 100
   port:
-    targetPort: ambient-ui-proxy
+    targetPort: oauthproxy
   tls:
     termination: edge
     insecureEdgeTerminationPolicy: Redirect

components/manifests/overlays/production/ambient-ui-service-patch.yaml

@@ -7,6 +7,6 @@ metadata:
 spec:
   ports:
   - port: 8443
-    targetPort: ambient-ui-proxy
+    targetPort: oauthproxy
     protocol: TCP
-    name: ambient-ui-proxy
+    name: oauthproxy

components/manifests/overlays/production/frontend-github-callback-patch.yaml

@@ -68,13 +68,6 @@ patches:
     kind: Service
     name: ambient-ui-service
     version: v1
-- path: frontend-github-callback-patch.yaml
-  target:
-    group: apps
-    kind: Deployment
-    name: frontend
-    version: v1
-
 # Production images
 images:
 - name: quay.io/ambient_code/vteam_api_server:latest