Commit 136db29
fix(control-plane,manifests): resolve MCP sidecar TLS and api-server proxy failures (#1546)
## Summary
- **MCP sidecar TLS fix**: The `ambient-mcp` sidecar container in runner
pods was missing the OpenShift `service-ca` volume mount and
`SSL_CERT_FILE` env var, causing `x509: certificate signed by unknown
authority` errors when calling `ambient-api-server` over HTTPS
(service-serving certs). Added both, matching the existing runner
container configuration.
- **Backend proxy fix**: The `ambient-api-server` reverse proxy plugin
defaults `BACKEND_URL` to `http://localhost:8080` when unset. Since the
backend runs in a separate pod (`backend-service:8080`), all proxied
requests (credentials, session listing) returned 502. Added
`BACKEND_URL` to the production env patch.
## Root Cause
These issues were exposed by the `ambient-control-plane` deployment fix
(env[15] `value`/`valueFrom` conflict on `CP_RUNTIME_NAMESPACE`). Once
the control-plane was redeployed with the correct manifest, the MCP
sidecar started being injected into runner pods, surfacing the missing
TLS config. The `BACKEND_URL` gap has existed since the api-server proxy
plugin was introduced but was previously masked.
## Test plan
- [ ] Deploy updated `ambient-control-plane` image to cluster
- [ ] Create a new session and verify MCP tools (`list_sessions`,
`list_projects`) work without TLS errors
- [ ] Verify credential fetching (github, gitlab, etc.) returns proper
responses instead of 502
- [ ] Verify `acp_list_sessions` works without 502
🤖 Generated with [Claude Code](https://claude.ai/code)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Chores**
* Enhanced MCP sidecar container configuration to support TLS
certificate validation and CA bundle access for secure internal
communication.
* Configured the API server with backend service endpoint URL settings
for production deployments, enabling proper service-to-service
connectivity in the ambient control plane.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---------
Co-authored-by: user <u@example.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>1 parent a455af3 commit 136db29
2 files changed
Lines changed: 11 additions & 0 deletions
File tree
- components
- ambient-control-plane/internal/reconciler
- manifests/overlays/production
Lines changed: 9 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
840 | 840 | | |
841 | 841 | | |
842 | 842 | | |
| 843 | + | |
843 | 844 | | |
844 | 845 | | |
845 | 846 | | |
| |||
862 | 863 | | |
863 | 864 | | |
864 | 865 | | |
| 866 | + | |
| 867 | + | |
| 868 | + | |
| 869 | + | |
| 870 | + | |
| 871 | + | |
| 872 | + | |
| 873 | + | |
865 | 874 | | |
866 | 875 | | |
867 | 876 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
0 commit comments