Skip to content

Commit 90bd769

Browse files
committed
fix: examples should follow Conventional Commits conventions
Also in English, most of the time you don't write a capital letter after colon
1 parent 67cbd7a commit 90bd769

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

README.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ Used by: [Electron](https://github.com/electron/electron) · [Vite](https://gith
77
## Examples
88

99
**Valid pull request titles:**
10-
- fix: Correct typo
11-
- feat: Add support for Node.js 18
12-
- refactor!: Drop support for Node.js 12
13-
- feat(ui): Add `Button` component
10+
- fix: correct typo
11+
- feat: add support for Node.js 18
12+
- refactor!: drop support for Node.js 12
13+
- feat(ui): add `Button` component
1414

1515
> Note that since pull request titles only have a single line, you have to use `!` to indicate breaking changes.
1616
@@ -117,7 +117,7 @@ For work-in-progress PRs you can typically use [draft pull requests from GitHub]
117117
**Example:**
118118
119119
```
120-
[WIP] feat: Add support for Node.js 18
120+
[WIP] feat: add support for Node.js 18
121121
```
122122
123123
This will prevent the PR title from being validated, and pull request checks will remain pending.

0 commit comments

Comments
 (0)