From e90317d83524b57e2d3713bea2df4fa9bfda9541 Mon Sep 17 00:00:00 2001 From: Nirmal Date: Sun, 28 Oct 2018 12:56:31 +0100 Subject: [PATCH] Fix bug which ignored AMADEUS_HOST property provided by environment API documentation suggests that the user can pass a custom domain to which the client will issue api calls, by setting a AMADEUS_HOST property in the system environment variable. This functionality was however broken due to a typo while reading the environment variable. Fix bug by correcting the typo, thus picking the correct env variable --- src/main/java/com/amadeus/Configuration.java | 2 +- src/test/java/com/amadeus/AmadeusTest.java | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/main/java/com/amadeus/Configuration.java b/src/main/java/com/amadeus/Configuration.java index d7a25aec..c25bf246 100644 --- a/src/main/java/com/amadeus/Configuration.java +++ b/src/main/java/com/amadeus/Configuration.java @@ -149,7 +149,7 @@ public Configuration setSsl(Boolean ssl) { // Parses environment variables and initializes the values. protected Configuration parseEnvironment(Map environment) { setHostname(getOrDefault(environment, "HOSTNAME", hostname)); - setHost(getOrDefault(environment, "HOOST", host)); + setHost(getOrDefault(environment, "HOST", host)); setLogLevel(getOrDefault(environment, "LOG_LEVEL", logLevel)); setSsl(Boolean.parseBoolean(getOrDefault(environment, "SSL", String.valueOf(ssl)))); setPort(Integer.parseInt(getOrDefault(environment, "PORT", String.valueOf(port)))); diff --git a/src/test/java/com/amadeus/AmadeusTest.java b/src/test/java/com/amadeus/AmadeusTest.java index 441e4800..cf53f931 100644 --- a/src/test/java/com/amadeus/AmadeusTest.java +++ b/src/test/java/com/amadeus/AmadeusTest.java @@ -31,6 +31,7 @@ public void testBuilderWithNullClientSecret() { put("AMADEUS_CLIENT_SECRET", "234"); put("AMADEUS_LOG_LEVEL", "debug"); put("AMADEUS_PORT", "123"); + put("AMADEUS_HOST", "my.custom.host.com"); } }; assertTrue("should return a Configuration", @@ -39,6 +40,7 @@ public void testBuilderWithNullClientSecret() { Amadeus amadeus = Amadeus.builder(environment).build(); assertEquals(amadeus.getConfiguration().getLogLevel(), "debug"); assertEquals(amadeus.getConfiguration().getPort(), 123); + assertEquals(amadeus.getConfiguration().getHost(), "my.custom.host.com"); } /*