From cfce75b717d51c8e411077eeb0bd5b2625274c12 Mon Sep 17 00:00:00 2001 From: Ramon Fritsch Date: Sat, 10 Dec 2016 02:30:10 -0800 Subject: [PATCH 1/2] fix(): basefacebook.getAccessTokenFromCode() removed hasOwnProperty after querystring.parse as querystring.parse returns an empty Object(null) without methods --- lib/basefacebook.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/basefacebook.js b/lib/basefacebook.js index 9f98652..5f0fdc5 100644 --- a/lib/basefacebook.js +++ b/lib/basefacebook.js @@ -1041,7 +1041,7 @@ BaseFacebook.prototype.getAccessTokenFromCode = function getAccessTokenFromCode( } else { var responseParams = querystring.parse(accessTokenResponse); - if (!responseParams.hasOwnProperty('access_token')) { + if (!responseParams['access_token']) { return false; } else { From cc383663452a1a2dd817c5397ef5a4666fb8fead Mon Sep 17 00:00:00 2001 From: Ramon Fritsch Date: Thu, 25 May 2017 21:00:28 -0700 Subject: [PATCH 2/2] fixes #26 - crash on BaseFacebook.hasCookie --- lib/basefacebook.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/basefacebook.js b/lib/basefacebook.js index 5f0fdc5..a91bf48 100644 --- a/lib/basefacebook.js +++ b/lib/basefacebook.js @@ -78,7 +78,7 @@ BaseFacebook.prototype.getCookie = function(key) { }; BaseFacebook.prototype.hasCookie = function(key) { - return this.request && this.request.cookies && this.request.cookies.hasOwnProperty(key); + return this.request && this.request.cookies && Object.prototype.hasOwnProperty.call(this.request.cookies, key); }; BaseFacebook.prototype.sentHeaders = function() {