Skip to content

x-forwarded-host is blindly trusted #23

Description

@dantman

In BaseFacebook I see 2 methods that blindly do something like headers['x-forwarded-host'] || headers.host.

The x-forwarded-host is not trustworthy, it can only be trusted if you know that there is a reverse proxy directly in front of node that sets it (express has it's own config for this). Otherwise x-forwarded-host can be manipulated to anything by the client.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions