Merge pull request #195 from akevinge/fix/failed-extension-ignores-filename

fix: check filename if no extensions match

Author: alstr

main.py

@@ -564,11 +564,13 @@ def _get_file_details(self, file):
         """Try and get the Markdown language and comment syntax data for the given file."""
         file_name, extension = os.path.splitext(os.path.basename(file))
         for language_name in self.languages_dict:
+            # Check if the file extension matches the language's extensions.
             if extension != "" and 'extensions' in self.languages_dict[language_name]:
                 syntax_details, ace_mode = self._get_language_details(language_name, 'extensions', extension)
                 if syntax_details is not None and ace_mode is not None:
                     return syntax_details, ace_mode
-            elif 'filenames' in self.languages_dict[language_name]:
+            # Check if the file name matches the language's filenames.
+            if 'filenames' in self.languages_dict[language_name]:
                 syntax_details, ace_mode = self._get_language_details(language_name, 'filenames', file_name)
                 if syntax_details is not None and ace_mode is not None:
                     return syntax_details, ace_mode

tests/test_new.diff

@@ -201,6 +201,20 @@ index 0000000..525e25d
 +    #  This function should probably do something more interesting
 +    #  labels: help wanted
 +    pass
+diff --git a/tests/BUILD.bazel b/tests/BUILD.bazel
+new file mode 100644
+index 0000000..525e25d
+--- /dev/null
++++ b/tests/BUILD.bazel
+@@ -0,0 +1,23 @@
++def hello_world():
++    # TODO: Come up with a more imaginative greeting
++    print('Hello world')
++
++    # TODO: Do more stuff
++    #  This function should probably do something more interesting
++    #  labels: help wanted
++    pass
 diff --git a/tests/example_file.ahk b/src/tests/example_file.ahk
 new file mode 100644
 index 0000000..7cccc5b

tests/test_todo_parser.py

@@ -23,8 +23,8 @@ def setUp(self):
         self.raw_issues = parser.parse(diff_file)
 
     def test_python_issues(self):
-        # Includes 2 tests for Starlark.
-        self.assertEqual(count_issues_for_file_type(self.raw_issues, 'python'), 6)
+        # Includes 4 tests for Starlark.
+        self.assertEqual(count_issues_for_file_type(self.raw_issues, 'python'), 8)
 
     def test_yaml_issues(self):
         self.assertEqual(count_issues_for_file_type(self.raw_issues, 'yaml'), 2)
@@ -56,7 +56,7 @@ def test_julia_issues(self):
         self.assertEqual(count_issues_for_file_type(self.raw_issues, 'julia'), 2)
 
     def test_starlark_issues(self):
-        self.assertEqual(count_issues_for_file_type(self.raw_issues, 'python'), 6)
+        self.assertEqual(count_issues_for_file_type(self.raw_issues, 'python'), 8)
 
     def test_autohotkey_issues(self):
         self.assertEqual(count_issues_for_file_type(self.raw_issues, 'autohotkey'), 1)