Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default theme name in make script to append the date #90

Closed
kevinfodness opened this issue Apr 18, 2024 · 3 comments
Closed

Update default theme name in make script to append the date #90

kevinfodness opened this issue Apr 18, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers php Requires understanding PHP

Comments

@kevinfodness
Copy link
Member

Description

To ensure there are different textdomains between the plugin and the theme, we should append the current year to the name of the theme when suggesting a theme name in the make script.

Use Case

When a user uses the make script to bootstap a project, it should suggest a theme name with the current year appended. For example, given a project name of example-project, the plugin slug should default to example-project and the theme slug should default to example-project-2024.

@kevinfodness kevinfodness added enhancement New feature or request php Requires understanding PHP labels Apr 18, 2024
@kevinfodness kevinfodness added the good first issue Good for newcomers label Jul 9, 2024
@goodguyry
Copy link
Member

How about setting the default plugin name to have a -plugin suffix and leaving the theme name as-is?

Rationale: Having worked in a theme with a -2016 suffix for a while, that year ends up being a drag. It's one thing to notice code that seems a little outdated; the theme itself announcing its age can really compound the effect.

@kevinfodness
Copy link
Member Author

The rationale behind this is that the plugin should grow and evolve over time, but the theme is intended to represent a particular graphical treatment of the front-end, which is rooted in a point in time when those decisions were made. Particularly with block themes, which this framework was crated to use, what is in the theme ends up being very light - it's mostly styles and templates, not functionality (that belongs in the plugin). Since most of the PHP code work is being done in the plugin, it's better to have that be a short slug that identifies the site/client/platform in question (e.g., alley) rather than having plugin appended (e.g., alley-plugin). This separation of concerns also makes it easier to create a new theme when there is a redesign with an updated year slug.

@juliobranha juliobranha self-assigned this Jan 24, 2025
@kevinfodness
Copy link
Member Author

Closed via #117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers php Requires understanding PHP
Projects
None yet
Development

No branches or pull requests

3 participants