Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions for Testing This Repo #15

Closed
kevinfodness opened this issue Jun 23, 2023 · 1 comment · Fixed by #111
Closed

Add GitHub Actions for Testing This Repo #15

kevinfodness opened this issue Jun 23, 2023 · 1 comment · Fixed by #111
Assignees
Labels
ci/cd PR checks, deploys, automation enhancement New feature or request

Comments

@kevinfodness
Copy link
Member

kevinfodness commented Jun 23, 2023

User Story

As a maintainer of this repo, I want to ensure that changes to this repo don't break automated tests when a full installation, including a plugin and theme, are performed by a user.

Acceptance Criteria

  • Create a GitHub Action to ensure that changes to create-wordpress-plugin and create-wordpress-theme do not break this project.
  • Ensure these checks run on PRs against this repo and on a schedule.
  • Use the automatic installation script established in Add Installer Script #7 to ensure that the project is properly configured before testing, emulating user behavior.
  • Test against a VIP-type repo and a Pantheon-type repo to ensure both targets are supported.
@kevinfodness kevinfodness added the enhancement New feature or request label Jun 23, 2023
@benpbolton benpbolton added the ci/cd PR checks, deploys, automation label Oct 11, 2023
@srtfisher srtfisher self-assigned this Nov 14, 2023
@benpbolton
Copy link
Member

TLDR;

The AC as listed would be challenging to accomplish with all the mandatory user input prompts. If they were reduced to 'test the defaults' we should be able to get 90% of the way there... if there were --hosting=vip or --hosting=pantheon options, that would make it possible (assuming the rest of the defaults were possible).

@kevinfodness I'm uncertain whether this is actionable yet with the current state of the configure.php script (@srtfisher may be able to validate my brief examination).

In particular, when specifying the three command-line options, the user is still prompted (though the defaults are updated). So running, for instance:

php ./configure.php --project_name=cwp --author_name=cwp [email protected]

will still prompt the user:

Image

If we remove the fourth AC (test both Pantheon and VIP), we can make some progress here. By leveraging yes or another tool or utility, we could test the 'all the defaults' option, which would be better than nothing. For instance:

Image

(just accept all defaults). Notably, this seems like it would use the Pantheon hosting option as the default:

Image

... alternatively a fragile implementation (would break or act unexpectedly when new options or questions are added or removed) we could supply the responses ahead of time (answer yes, yes, no , no, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd PR checks, deploys, automation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants