feat: 쿠키 설정 추가 #65
Open
feat: 쿠키 설정 추가 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Test Results59 tests 46 ✅ 3s ⏱️ For more details on these failures, see this check. Results for commit 11cbd8b. |
|
테스트가 많이 깨지네요. 토큰이 필요한 로직에서 토큰을 전달하지 않아서 그런 것 같아요. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
쿠키에 아무런 설정이 되어 있지 않아서, 추가해요. 추가한 설정은 다음과 같아요.
httponly, secure,samesite는 기본으로 설정했고, path는 최상단 경로인
/, 만료 시간은 영구에 가깝게 6년을 설정했어요. 6년이면 신입생이 졸업하고 남지 않을까요? ㅎㅎ