Skip to content

Commit dcece1d

Browse files
committed
[GraphEditor] Stop manually editing pins based on the edge's visibility
Editing the pins manually was useful when trying to hide fully the connection whenever there was an edge connected to an attribute that was disabled. Disabled attributes now have a special display if they are connected, meaning both ends of the edge do not need artificial updates.
1 parent e5189fb commit dcece1d

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

meshroom/ui/qml/GraphEditor/GraphEditor.qml

-16
Original file line numberDiff line numberDiff line change
@@ -521,22 +521,6 @@ Item {
521521
}
522522
}
523523
}
524-
onVisibleChanged: {
525-
if (visible) {
526-
// Enable the pins on both sides
527-
src.updatePin(true, true) // isSrc = true, isVisible = true
528-
dst.updatePin(false, true) // isSrc = false, isVisible = true
529-
} else {
530-
// One of the attributes is visible, we do not need to handle the case where both attributes are hidden
531-
if (isValidEdge && (src.visible || dst.visible)) {
532-
if (src.visible) {
533-
src.updatePin(true, false) // isSrc = true, isVisible = false
534-
} else {
535-
dst.updatePin(false, false) // isSrc = false, isVisible = false
536-
}
537-
}
538-
}
539-
}
540524

541525
Component.onDestruction: {
542526
// Handles the case where the edge is destroyed while hidden because it is replaced: the pins should be re-enabled

0 commit comments

Comments
 (0)