Skip to content

Extracting feature matching geometric filter into new nodes for external matchers #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 17, 2025
Merged

Extracting feature matching geometric filter into new nodes for external matchers #1922

merged 7 commits into from
Oct 17, 2025

Conversation

@servantftransperfect
Copy link
Contributor

@servantftransperfect servantftransperfect commented Jul 18, 2025 •
edited by cbentejac
Loading

Add two new nodes/applications :

  • geometric filter estimation from a set of feature matches which generates a json file with the geometric filters found
  • geometric filter apply, which takes a set of feature matches and removes the matches which does not respect the filters given in input json file.

The goal is to split the logic of the FeatureMatching Node such that the geometric filtering is made available to feature matchers where the photommetric matching is done outside of aliceVision.

Related Meshroom PR: alicevision/Meshroom#2922

@servantftransperfect servantftransperfect added this to the 3.3.0 milestone Jul 18, 2025
@servantftransperfect servantftransperfect marked this pull request as draft July 22, 2025 14:30
@fabiencastan fabiencastan modified the milestones: 3.3.0, 3.4.0 Aug 1, 2025
@servantftransperfect servantftransperfect marked this pull request as ready for review October 9, 2025 15:57
@cbentejac cbentejac mentioned this pull request Oct 15, 2025
Merged
@cbentejac cbentejac force-pushed the dev/geometricFiltering branch from 14431b6 to 8901e1c Compare October 15, 2025 13:52
@cbentejac cbentejac force-pushed the dev/geometricFiltering branch from 8901e1c to a5c170a Compare October 16, 2025 17:26
@cbentejac cbentejac merged commit da701bf into develop Oct 17, 2025
3 of 4 checks passed
@cbentejac cbentejac deleted the dev/geometricFiltering branch October 17, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbentejac cbentejac cbentejac approved these changes

@CedricThebault CedricThebault Awaiting requested review from CedricThebault

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@servantftransperfect @cbentejac @fabiencastan