[Infra] Add clang-format check in GA

Summary: Add clang-format check in GA, and format updates

Test Plan: -

Reviewed-by: -

Issue: -

Author: oraluben

.github/workflows/check.yml

@@ -38,47 +38,46 @@ jobs:
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
-          python -m pip install nox flake8
-      - name: Lint with flake8
-        run: |
-          # Run line only once
-          # stop the build if there are Python syntax errors or undefined names
-          flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
-          # # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
-          # flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
+          python -m pip install nox
       - name: Test with pytest
         run: |
           nox -s tests_multiple_conda
 
-  test-imports:
+  test-twine:
     runs-on: ubuntu-latest
 
     steps:
       - uses: actions/checkout@v2
-      - uses: s-weigand/setup-conda@v1
-      - run: conda --version
+      - name: Set up Python
+        uses: actions/setup-python@v2
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
-          python -m pip install nox
-      - name: Test imports
+          python -m pip install nox twine
+      - name: Build sdist to test
+        run: |
+          nox -s build_sdist
+      - name: Test with twine
         run: |
-          nox -s test_import_third_party
+          twine check dist/*.tar.gz
 
-  test-twine:
+  check-format:
+    name: Formatting Check
     runs-on: ubuntu-latest
-
     steps:
       - uses: actions/checkout@v2
       - name: Set up Python
         uses: actions/setup-python@v2
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
-          python -m pip install nox twine
-      - name: Build sdist to test
-        run: |
-          nox -s build_sdist
-      - name: Test with twine
+          python -m pip install flake8
+      - name: Lint with flake8
         run: |
-          twine check dist/*.tar.gz
+          flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
+      - name: Run clang-format style check
+        uses: jidicula/[email protected]
+        with:
+          clang-format-version: '13'
+          check-path: 'src/_cds'
+          exclude-regex: '(clinic|pythoncapi_compat)'

.github/workflows/performance.yml

@@ -4,8 +4,22 @@ on:
   push:
     branches: [ main ]
 
-
 jobs:
+  test-import:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+      - uses: s-weigand/setup-conda@v1
+      - run: conda --version
+      - name: Install dependencies
+        run: |
+          python -m pip install --upgrade pip
+          python -m pip install nox
+      - name: Test import third-party packages
+        run: |
+          nox -s test_import_third_party
+
   perf-import:
     runs-on: ubuntu-latest
 
@@ -17,6 +31,6 @@ jobs:
         run: |
           python -m pip install --upgrade pip
           python -m pip install nox pyperf
-      - name: Run performance test
+      - name: Perf importing third-party packages
         run: |
           sh scripts/perf_import.sh

src/_cds/hashtable.c

@@ -1,3 +1,6 @@
+#include "lookup_table.h"
+
+#if PYCDS_HASHTABLE
 
 #include "hashtable.h"
 
@@ -150,3 +153,5 @@ hashtable_destroy(hashtable_t *ht)
     free(ht->buckets);
     free(ht);
 }
+
+#endif

src/_cds/lookup_table.c

@@ -6,7 +6,7 @@
 table *
 PyCDS_Table_New()
 {
-    table* t = calloc(1, sizeof(table));
+    table *t = calloc(1, sizeof(table));
 #if IS_HASHTABLE && CPYTHON_HASHTABLE
     t->pyHashtable = _Py_hashtable_new(_Py_hashtable_hash_ptr,
                                        _Py_hashtable_compare_direct);

src/_cds/lookup_table.h

@@ -11,7 +11,9 @@
 #include <Python.h>
 #if PY_VERSION_HEX >= 0x03090000
 #define CPYTHON_HASHTABLE 1
+#define PYCDS_HASHTABLE 0
 #else
+#define CPYTHON_HASHTABLE 0
 #define PYCDS_HASHTABLE 1
 #endif
 #endif