[Fix] Fix when package overwrites __path__ to a string. (#43)

Summary: Fix when package overwrites `__path__` to a string.

Test Plan: all

Reviewed-by: -

Issue: -

Author: oraluben

.github/workflows/check.yml

@@ -66,7 +66,7 @@ jobs:
         run: |
           nox -s test_import_third_party-${{ matrix.conda-py }}
       - name: Setup tmate session
-        if: ${{ failure() }}
+        if: ${{ failure() && false }}
         uses: mxschmitt/action-tmate@v3
 
   test-twine:

setup.py

@@ -10,7 +10,7 @@
 
 setup(
     name='code-data-share',
-    version='0.1.0',
+    version='0.0.3',
     packages=['cds'],
     package_dir={'': 'src'},
     python_requires='>=3.8.0',

src/cds/dump.py

@@ -45,7 +45,21 @@ def wrap_exec_module(self, module):
             # __path__ must be an iterable of strings,
             # we convert any valid __path__ to tuple of strings.
             # Ref: https://docs.python.org/3/reference/import.html#module-path
-            path = tuple(path) if path else None
+            if not path:
+                path = None
+            elif isinstance(path, str):
+                # Some package might change this, which is non-standard.
+                # There is no correct way to handle this.
+                # We retain the file location to maintain the original import function,
+                # and also record the `path` for debugging purposes.
+                import os.path
+                path = (os.path.dirname(file), path)
+            else:
+                try:
+                    path = tuple(path)
+                except TypeError:
+                    _verbose(f"{name}.__path__ is not iterable: {path}", 1)
+                    path = None
             meta_map[name] = (package, file, path)
             return module
 
@@ -68,8 +82,9 @@ def wrap_exec_module(self, module):
                 _verbose(f'executing module {line} triggers an SystemExit({e.code}), ignoring.', 1)
             except Exception as e:
                 _verbose(f'executing module {line} triggers an {e.__class__.__name__}, traceback:', 1)
+                import sys
                 import traceback
-                _verbose(''.join(traceback.format_exception(e)), 1)
+                _verbose(''.join(traceback.format_exception(*sys.exc_info())), 1)
 
     shared_class_data = tuple([(k, v) for k, v in {
         k: (*meta_map[k], code_map[k])