Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move OnCompleteAction out of arc4 #132

Closed
joe-p opened this issue Mar 10, 2025 · 2 comments · Fixed by #134
Closed

Move OnCompleteAction out of arc4 #132

joe-p opened this issue Mar 10, 2025 · 2 comments · Fixed by #134
Assignees
@tristanmenzel
Labels
released on @alpha released on @main

Comments

@joe-p
Copy link
Contributor

joe-p commented Mar 10, 2025

Problem

OnCompleteAction is current under arc4 but this is native AVM feature so it doesn't really fit in the ARC4 module.

Solution

Proposal

Move OnCompleteAction outside of arc4

Pros and Cons

Will make it easier for developers to find it when they need it

Dependencies
@tristanmenzel tristanmenzel self-assigned this Mar 10, 2025
@tristanmenzel tristanmenzel mentioned this issue Mar 10, 2025
Merged
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.0.0-beta.41 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.0.0-alpha.39 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tristanmenzel tristanmenzel

Labels
released on @alpha released on @main
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: Moves OnCompleteAction type out of /arc4 namespace algorandfoundation/puya-ts
2 participants
@tristanmenzel @joe-p