React 19 / React.JSX

[bagedevimo]

Using Algolia with React19 results in type errors, as JSX is no longer available on the global namespace, instead prefixed by JSX.

I'm happy to fix this, but wonder if you have an intended statregy for this kind of thing given the varied support for different rendering strategies.

[aymeric-giraudet]

Hey @bagedevimo, this lib doesn't ship any React component so I'm confused as to why and where there would be a problem ?

Could you please send us a reproduction first ?

[bagedevimo]

but yeah I think it's just literally in the type signatures of some interfaces / types, rather than an exported component

[aymeric-giraudet]

Ah yes this is probably because of Preact, I'll take a look !

[aymeric-giraudet]

Okay I was able to reproduce. This only seems to happen when skipLibCheck is false.

By default, Vite creates a tsconfig file with skipLibCheck set to true. Does it make sense to add this to your project ? This would at least be a quick workaround.

I'll still look at what can be done for those with skipLibCheck: false

[bagedevimo]

Yeah, i'll investigate that option for us. I'd obviously prefer to leave it disabled, as enabling it does slightly reduce the quality of the type-checking across our codebase. I wonder if the React team have thought about this problem.

[aymeric-giraudet]

Should be fixed with #1299, you can test by installing autocomplete-js (or autocomplete-core if that's what you use) from CSB before it's released :

yarn add https://pkg.csb.dev/algolia/autocomplete/commit/f1c5a730/@algolia/autocomplete-js