Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: c# V7 Recommend Client 'Get' behaviour no longer allows type arguments #863

Closed
AdTarling opened this issue Sep 3, 2024 · 1 comment

Comments

@AdTarling
Copy link

Description

Up until the most recent v6 release of the c# Recommend client, it was possible to use type arguments with the GET methods, in a similar fashion to the search client, e.g:

_recommendClient.GetRecommendationsAsync()
_recommendClient.GetRelatedProductsAsync()

However, with v7 there seem to only be non-generic GET methods, e.g:
_recommendClient.GetRecommendationsAsync()
_recommendClient.CustomGetAsync()

It feels like the v7 recommend client isn't finished yet? Is that correct, or is this currently overlooked behaviour, as it introduces some serious breaking changes if it's no longer possible to retrieve strongly typed records from the recommend requests?

Client

Recommend

Version

7.2.4

Relevant log output

No response

@millotp
Copy link
Contributor

millotp commented Sep 3, 2024

Hello, this is the expected behavior as the only thing changing between all functions is the body, they are all requesting the same endpoint.
The argument to GetRecommendationsAsync is still strongly typed, you can find an example in the documentation snippet.

I agree that the usage is not as straight forward as v6, but v7 reflects more closely the underlying api, and all the functionalities are still there.

@millotp millotp closed this as completed Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants